[ADMINCTR-286] CSS only partially extracted from UI Created: 10/Oct/22  Updated: 20/Mar/23

Status: Open
Project: Admincentral
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Roman Kovařík Assignee: Unassigned
Resolution: Unresolved Votes: 1
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Sub-Tasks:
Key
Summary
Type
Status
Assignee
ADMINCTR-287 Implementation Sub-task To Do  
ADMINCTR-288 Review Sub-task To Do  
ADMINCTR-289 Pre-Integration QA Sub-task To Do  
ADMINCTR-290 QA Sub-task To Do  
Template:
Acceptance criteria:
Empty
Date of First Response:
Epic Link: AuthorX Maintenance
Team: AuthorX

 Description   

Steps to reproduce

  1. Do a CSS fix, e.g https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/pull-requests/2211/diff#magnolia-resurface-theme/src/main/resources/VAADIN/themes/resurface/dialogs.scss 
  2. Build UI project
  3. Make sure the correct version of UI is in the changelog/bundle
  4. Test the change

Expected results

Without any deep knowledge of dependencies, I expect that

  • the build of the changed git project should be enough to apply the changes
  • presence of this module in bundle/changelog makes sure the change will be released

Actual results

The changes are not applied unless the admincentral is built/included in the bundle as well.

Workaround

Make sure admincentral version is built / version is updated as well.

Development notes

One solution would be to have both UI and ADMINCENTRAL tickets for every CSS change but that seems to be an overkill and still would require building two different projects.

As theme and admincentral (even though there were thoughts to make the theme pluggable) were always dependent parts, it might make sense to move the resurface-theme UI submodule to the admincentral reactor as well:

  • All css issues would be created in ADMINCENTRAL project (this would also solve the reoccurring "who owns the CSS" issue)
  • missing admincentral would be catched by automated checks in PR builds/release process
  • developers would need only one project to apply the changes

 



 Comments   
Comment by Mikaël Geljić [ 21/Nov/22 ]

Thinking about options:

  • could move the whole resurface theme to admincentral, as there is no other consumer of this; downside is that it moves styles away from widget code
  • alternatively, do the final theme compilation on CE/webapp level (either moving what we call resurface-admincentral theme there, or creating a new aggregating theme on top)
  • force re-release in sequence all the time and snapshot rollback (via Foundation tooling)
Generated at Sun Feb 11 23:05:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.