[ADMINCTR-296] RichTextField height parameter ignored when dialog is wide Created: 17/Jan/22  Updated: 11/Oct/22  Resolved: 04/Oct/22

Status: Closed
Project: Admincentral
Component/s: None
Affects Version/s: 6.2.23
Fix Version/s: 6.3.0, 6.2.24

Type: Bug Priority: Neutral
Reporter: Roberto Gaona Assignee: Quach Hao Thien
Resolution: Fixed Votes: 3
Labels: RichTextField, css
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 1.25d Time Spent: 0.5d
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: PNG File image-2022-01-17-11-52-00-748.png    
Issue Links:
causality
Sub-Tasks:
Key
Summary
Type
Status
Assignee
ADMINCTR-297 Provide PR Sub-task Completed Quach Hao Thien  
ADMINCTR-298 PreintQA Sub-task Completed Adam Siska  
ADMINCTR-299 Review Sub-task Completed Adam Siska  
ADMINCTR-300 QA Sub-task Completed Sang Ngo Huu  
Template:
Acceptance criteria:
Empty
Release notes required:
Yes
Date of First Response:
Epic Link: Nucleus Quality Maintenance
Sprint: Nucleus 20
Story Points: 2
Team: Nucleus

 Description   

Steps to reproduce

  1. Create a dialog with the following structure:
form:
  properties:
    - name: text
      $type: richTextField
      height: 150
wide: true

Expected results

Dialog appears wide and with the set height

Actual results

Dialog ignores the height set on the field and expands it:

Workaround

Development notes



 Comments   
Comment by Christopher Chard [ 01/Feb/22 ]

This is pretty big usability impact for us as many of our dialogs are affected.

Please fix quickly. Thx!

Comment by Jaromir Sarf [ 09/Sep/22 ]

Discovery:

Wide size styles always rewrite height which was set in yaml config.

Solution: Remove !important from (in magnolia-resurface-theme/src/main/resources/VAADIN/themes/resurface/dialogs.scss):

.v-ckeditortextfield {
  height: calc(100vh - 216px) !important;
}
.v-treegrid, .v-treegrid-tablewrapper, .v-grid, .v-grid-tablewrapper, .cke_contents {
 height: calc(100vh - 260px) !important; 
}
Comment by Roman Kovařík [ 16/Sep/22 ]

Check the commit which added !important.

Generated at Sun Feb 11 23:05:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.