[ADMINCTR-408] Close action should work the same way as X-ing out Created: 13/Oct/22  Updated: 03/Jul/23  Resolved: 03/Jul/23

Status: Closed
Project: Admincentral
Component/s: None
Affects Version/s: 6.2.31
Fix Version/s: 6.3.0, 6.2.32

Type: Bug Priority: Neutral
Reporter: Richard Gange Assignee: Adam Siska
Resolution: Fixed Votes: 0
Labels: Nucleus_AuthX_Support
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: PNG File x-vs-close.png    
Issue Links:
causality
is causing ADMINCTR-420 Make subapp closing behaviour configu... Open
relation
Sub-Tasks:
Key
Summary
Type
Status
Assignee
ADMINCTR-409 Implementation Sub-task Completed Adam Siska  
ADMINCTR-410 Code review Sub-task Completed Jaromir Sarf  
ADMINCTR-411 Preint QA Sub-task Closed Antonín Juran  
ADMINCTR-412 QA Sub-task Completed Jaromir Sarf  
ADMINCTR-413 Decide on solution Sub-task Completed Dominik Maslanka  
ADMINCTR-419 Port to master (wait for green 6.2 do... Sub-task Completed Adam Siska  
Template:
Acceptance criteria:
Empty
Release notes required:
Yes
Date of First Response:
Epic Link: AuthorX Support
Sprint: Nucleus 39
Story Points: 2
Team: AuthorX
Work Started:
Approved:
Yes

 Description   

Currently when you "X-out" of a subapp you return to the browser (or whatever app is first). OTOH when using the close action you return to whichever subapp is closest. In some cases it's not the same. For example, when you have 3 or more subapps open.

Reproduce

  • Open the Groovy app.
  • Edit (open) a groovy script.
  • Close using the 'X' --> returns to browser
  • Edit (open) the script again.
  • Close using the close button --> returns to the console

It's not limited to the Groovy app. The same behavior can be created in any app where 3 or more tabs are open. For example, two detail subapps open. Two assets or two pages.

Expected
Users expect the same behavior for both which is return to browser.

Actual
The close behavior returns to the closest tab and not the always the browser.



 Comments   
Comment by Jaromir Sarf [ 08/Jun/23 ]

Discovery:
After closing a subapp we are focusing a subapp chosen from 

 

app.getView().getActiveSubAppView() 

in https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/magnolia-ui-framework/src/main/java/info/magnolia/ui/framework/app/AppInstanceControllerImpl.java#275. In every case(X button, close button) we will get different instanceId there, so we will focus a different subapp after closing the active one. As solution we could distinguish the default subapp from subApps map and set this one as ActiveSubAppView, or pass its instanceId to onFocus method.

 

Comment by Jaromir Sarf [ 09/Jun/23 ]

Next option:
Both actions will be behaving the same when these condition will be removed. https://git.magnolia-cms.com/projects/MODULES/repos/admincentral/browse/magnolia-admincentral/src/main/java/info/magnolia/admincentral/AdmincentralAppView.java?at=release%2F6.2#98

Comment by Adam Siska [ 03/Jul/23 ]

At the end we decided for solution which returns to browser subapp always (with any UI action). Also improvement ticket was filed to tackle future issues with closing: https://jira.magnolia-cms.com/browse/ADMINCTR-420

Generated at Sun Feb 11 23:06:51 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.