[ADMINCTR-438] Context menu is no longer scrollable Created: 12/Jul/23  Updated: 18/Sep/23  Resolved: 31/Aug/23

Status: Closed
Project: Admincentral
Component/s: None
Affects Version/s: None
Fix Version/s: 6.3.0, 6.2.34

Type: Bug Priority: Neutral
Reporter: Richard Gange Assignee: Jaromir Sarf
Resolution: Fixed Votes: 0
Labels: Nucleus_AuthX_Support
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 3.5h Time Spent: 3.5h
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: PNG File javascript-warnings.png    
Issue Links:
relation
Sub-Tasks:
Key
Summary
Type
Status
Assignee
ADMINCTR-468 Implementation Sub-task Completed Jaromir Sarf  
ADMINCTR-469 Code review Sub-task Completed Quach Hao Thien  
ADMINCTR-470 Pre-Integration QA Sub-task Completed Quach Hao Thien  
ADMINCTR-471 QA Sub-task Completed Adam Siska  
Template:
Acceptance criteria:
Empty
Release notes required:
Yes
Date of First Response:
Sprint: Nucleus 44
Story Points: 2
Team: Nucleus
Work Started:
Approved:
Yes

 Description   

In any app try to bring up the magnolia context menu (i.e. right-click). In the cases of the longer menus the bottom gets cut-off and is no longer accessible using scroll.
See this video

Reproduce

  • Open the pages app.
  • Right click on a page.
  • Try to scroll down on the menu.

Expected
I should be able to click all items on the context menu.

Actual
Items at the bottom of the menu cannot be reached.

Workaround
Use the down arrow key to reach the items at the bottom.

Notes
There are some Javascript warnings in the console



 Comments   
Comment by Jaromir Sarf [ 27/Jul/23 ]

Discovery:
The bug was caused in this PR https://git.magnolia-cms.com/projects/MODULES/repos/admincentral/pull-requests/101/diff#magnolia-admincentral/src/main/resources/info/magnolia/admincentral/usermenu/usermenu.css. We disabled scroll by:

.resurface-admincentral > .v-menubar-popup {
  overflow-y: unset !important;
}

because the new change overrides this style https://git.magnolia-cms.com/projects/PLATFORM/repos/ui.pub/browse/magnolia-resurface-theme/src/main/resources/VAADIN/themes/resurface/contextmenu.scss?at=refs%2Fheads%2Frelease%2F6.2#14.

Possible solutions:

to

overflow: scroll !important; 

here : https://git.magnolia-cms.com/projects/PLATFORM/repos/ui.pub/browse/magnolia-resurface-theme/src/main/resources/VAADIN/themes/resurface/contextmenu.scss?at=refs%2Fheads%2Frelease%2F6.2#14.

 

Generated at Sun Feb 11 23:07:07 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.