[ANALYTICS-148] Provide registry for ChartDefinition Created: 11/May/20 Updated: 02/Apr/21 Resolved: 04/Jun/20 |
|
| Status: | Closed |
| Project: | Analytics |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.2 |
| Type: | Story | Priority: | Neutral |
| Reporter: | Oanh Thai Hoang | Assignee: | Thuy To |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 3d 7.75h | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Release notes required: |
Yes
|
||||||||
| Documentation update required: |
Yes
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | Analytics UI dashboard | ||||||||
| Sprint: | Add-Ons 39 | ||||||||
| Story Points: | 5 | ||||||||
| Description |
|
Current behaviour: We register chart definition in dashboard and we don't have registry for ChartDefinition so chart definition maybe duplicate in case we like to have one chart with different supplier Expectation: User now can configure new chart definition in registry
Before:
chartDefinitions:
triangle-column-chart:
dataSupplier: demoMatomoSupplierForGettingVisitPerPage
label: triangle-column-chart
class: info.magnolia.analytics.amcharts.data.AmChartDefinition
# Here is sample config for https://www.amcharts.com/demos/triangle-column-chart/
chartType: !include:/analytics-ui/chartTypes/column-and-bar/triangle-column.yaml
Expect: Register triangle-colum-chart in another registry and dashboard now: chartDefinitions: chart-1: triangle-column-chart |
| Comments |
| Comment by Thuy To [ 25/Jun/20 ] |
|
Hi jlegendre, This is how to registry a chart in dashboard after code changed.
Example: how to registry a timeline chart in dashboard Before: chartDefinitions: timeline-chart: label: timeline-chart class: info.magnolia.analytics.amcharts.data.AmChartDefinition dataSupplier: testDataSupplier chartType: !include:/analytics-ui/chartTypes/timeline/timeline.yaml type: SerpentineChart After: chartDefinitions: timeline-chart: !include:/analytics-ui/charts/timeline/timeline.yaml
Note: make sure a timeline chart existing in charts folder of Definitions. Please feel free to contact me if you have any question. Thanks, Thuy To |