[ANALYTICS-149] Provide registry for DataSupplier Created: 11/May/20 Updated: 02/Apr/21 Resolved: 18/Jun/20 |
|
| Status: | Closed |
| Project: | Analytics |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.2 |
| Type: | Story | Priority: | Neutral |
| Reporter: | Oanh Thai Hoang | Assignee: | Yen Lac Tue |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 4d 3h 25m | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||
| Release notes required: |
Yes
|
||||||||||||||||||||
| Documentation update required: |
Yes
|
||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||
| Epic Link: | Analytics UI dashboard | ||||||||||||||||||||
| Sprint: | Add-Ons 40 | ||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||
| Description |
|
Current behaviour: We register datasupplier in dashboard and we don't have registry for datasupplier so datasupplier maybe duplicate Expectation: User now can configure new datasupplier in registry
Dashboard before:
dataSuppliers:
demoMatomoSupplierForGettingVisitPerPage:
class: info.magnolia.analytics.matomo.datasource.MatomoDataSupplier
credentials:
parameters:
serverUrl: https://demo.matomo.org
tokenAuth: anonymous
parameters:
method: VisitorInterest.getNumberOfVisitsPerPage
module: API
idSite: 62
date: yesterday
period: day
format: json
filter_limit: 5
Dashboard now: does not have datasupplier, data supplier will be reference in chart definition instead
AC: Refresh action has been impact after user add new chart type into current dashboard. Please resolve TODO and make sure refresh action works as normal when implementing this change. |
| Comments |
| Comment by Yen Lac Tue [ 18/Jun/20 ] |
|
Hi jlegendre, There is changing the way to register dataSupplier for dashboard. In previous version, the dataSuppliers information are put in dashboard yaml file.
Base on this ticket, now the dataSuppliers information is removed from dashboard yaml file and registry under this directory: /resource/<module name>/dataSuppliers/<dataSupplierRegistryFile.yaml> Note:
Please feel free to contact me if you have any question Thanks, Yen Lac
|