[ANALYTICS-263] Prevent users from using special characters in widget names Created: 10/Nov/20  Updated: 26/Jan/21  Resolved: 22/Jan/21

Status: Closed
Project: Analytics
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2

Type: Improvement Priority: Neutral
Reporter: Julie Legendre Assignee: Yen Lac Tue
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 2d 2h 59m
Original Estimate: Not Specified

Attachments: Text File analytics widget name special character error.txt    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: UI/UX Dash improvements
Sprint: Add-Ons 55, Add-Ons 56
Story Points: 3

 Description   

To reproduce, for example:

  1. In the analytics app, add an Adobe widget with the name Adobe "Unique Visitor" commonly used metrics and Unique visitors as the metric selected.
  2. Clicked Add to dashboard, the demo dashboard disappears and an error is in the log (see txt file attached). The demo dashboard no longer appears in the dashboard dropdown.

Expected behavior: users should be prevented from using unauthorized characters in the name field.

 

 

Update : This bug can reproduce in Add new dashboard action as well



 Comments   
Comment by Julie Legendre [ 19/Jan/21 ]

Hi yen.lactue ,
What about this message, is it correct?
The name cannot contain non-alphabetic or non-numeric characters, such as @, #, $, %, &, * and +.

Comment by Antonín Juran [ 19/Jan/21 ]

jlegendre Wouldn't be better to list all invalid characters:
!"#$%&'()*+,-./:;<=>?@[]^_`{|}~
See https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html - \p{Punct}

Comment by Julie Legendre [ 21/Jan/21 ]

Yes, thank you ajuran for the list   Sorry I missed the comment earlier!

So in the end yen.lactue:
The name cannot contain the following non-alphabetic or non-numeric characters: ! " # $ % & ' ( ) * + , - . / : ; < = > ? @ [ ] ^ _ ` { | } ~.
 
 

Comment by Yen Lac Tue [ 21/Jan/21 ]

Thanks jlegendre and ajuran

Comment by Julie Legendre [ 25/Jan/21 ]

After dialog width issues and discussions with Yen, plus validation by Anja, we decided to go with: 
The name can not contain special characters.

Generated at Sun Feb 11 23:17:10 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.