[ANALYTICS-52] DataSuppliers should get client configuration details from DashboardDefinition Created: 27/Mar/19  Updated: 17/Apr/19  Resolved: 09/Apr/19

Status: Closed
Project: Analytics
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: Improvement Priority: Neutral
Reporter: Ilgun Ilgun Assignee: Chuong Doan Huy
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 6.5h
Original Estimate: Not Specified

Issue Links:
dependency
depends upon ANALYTICS-30 Introduce GA auth Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Analytics backend
Sprint: Add-Ons 9
Story Points: 2

 Description   

Currently, our dataSupplier use ChartDefinition#Options differently than it was intended to be. If one gives a look at info.magnolia.analytics.matomo.datasource.MatomoDataSupplierTest it's obvious that chartDefinition.getOptions() are used differently. Normally they are intended to be filters which are applied to the dataSupplier as query or path parameters so far so good but credentials or  link to the server shouldn't be done via Options. Those information should come from DashboardDefinition. DashboardDefinition knows about all the dataSuppliers and chartDefinition knows about which dataSupplier it should get the data from. Hence, Specific dataSupplier should be in the beginning created with correct credentials. 

 

Acceptance Criteria:

  • Use dashboardDefinition in the DataSuppliers
  • Initialise DataSupplier with correct information which comes from DashboardDefinition (aka credentials, urls etc)
  • Use Options only for specific calls to dataSuppliers e.g. country=VN
  • Adjust tests accordingly

 



 Comments   
Comment by Chuong Doan Huy [ 09/Apr/19 ]

Done in ticket ANALYTICS-30

Generated at Sun Feb 11 23:15:02 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.