[ANALYTICS-52] DataSuppliers should get client configuration details from DashboardDefinition Created: 27/Mar/19 Updated: 17/Apr/19 Resolved: 09/Apr/19 |
|
| Status: | Closed |
| Project: | Analytics |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Ilgun Ilgun | Assignee: | Chuong Doan Huy |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 6.5h | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | Analytics backend | ||||||||
| Sprint: | Add-Ons 9 | ||||||||
| Story Points: | 2 | ||||||||
| Description |
|
Currently, our dataSupplier use ChartDefinition#Options differently than it was intended to be. If one gives a look at info.magnolia.analytics.matomo.datasource.MatomoDataSupplierTest it's obvious that chartDefinition.getOptions() are used differently. Normally they are intended to be filters which are applied to the dataSupplier as query or path parameters so far so good but credentials or link to the server shouldn't be done via Options. Those information should come from DashboardDefinition. DashboardDefinition knows about all the dataSuppliers and chartDefinition knows about which dataSupplier it should get the data from. Hence, Specific dataSupplier should be in the beginning created with correct credentials.
Acceptance Criteria:
|
| Comments |
| Comment by Chuong Doan Huy [ 09/Apr/19 ] |
|
Done in ticket |