[ANALYTICS-81] Exception throws when user don’t have positions defined in chart definition Created: 11/Jun/19  Updated: 02/Jul/19  Resolved: 19/Jun/19

Status: Closed
Project: Analytics
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Oanh Thai Hoang Assignee: Chuong Doan Huy
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1d 7h 31.5m
Original Estimate: Not Specified

Attachments: PNG File 1-1-dimension.png     PNG File 1-2-dimension.png     PNG File 1-3-dimension.png     PNG File no-dimension.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Documentation update required:
Yes
Date of First Response:
Epic Link: Analytics UI
Sprint: Add-Ons 14
Story Points: 2

 Description   

Current behavior:

Now user need to configure specific position for each chart https://git.magnolia-cms.com/projects/ADDON/repos/analytics/browse/magnolia-analytics-ui/src/main/resources/analytics-ui/dashboards/test.yaml#5

In case user don't specify the position, exception will be throw and dash board can't load

 

AC:

In case user don't specify the position, the chart still add to any free location in dashboard and no exception at all

 

Hint: I suggest used com.vaadin.ui.GridLayout#addComponent(com.vaadin.ui.Component) in case position does not exit, pls check

 

 



 Comments   
Comment by Chuong Doan Huy [ 19/Jun/19 ]

Hi jlegendre,

With this ticket, the changes for charts's position configuration updated as below :

  • Without configuration for "dimension" and "position", charts still shown with two-column layout as default. The number of rows is dynamic based on number of charts (when adding more chart, rows automatically increased, don't need to configure). This config is recommended for new users.
  • With explicitly configured "dimension" and "position", charts will display as it is (same as before). Please be aware that "dimension" and "position" are related to each other, if not correctly setting (e.g dimension 2x2 but position is 3 or 4 which out of range) these may cause errors. This config is for advanced users who want to customize positions for their own purposes.
Comment by Le Hai Thanh [ 26/Jun/19 ]

QA

no dimension

1 row 3 cols

1 row - 4 cols

1 row 1 col

Comment by Julie Legendre [ 02/Jul/19 ]

thanks for the info chuong.doan!

 

Generated at Sun Feb 11 23:15:19 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.