[ARCH-16] Project properties generated by the different archetypes should be consistently named Created: 11/Jul/11  Updated: 14/Mar/14  Resolved: 04/Aug/11

Status: Closed
Project: Archetypes
Component/s: forge-module, module, project, stk-theme
Affects Version/s: 1.0
Fix Version/s: 1.1

Type: Bug Priority: Neutral
Reporter: Matt Dertinger Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: archetypes, build, modules, stk
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

Hi,

First off, I'd like to say I really like the new archetypes, thanks a bunch.

One thing I noticed was that some of the project properties are not consistently named. For instance, the pom.xml file that gets generated when using project archetype contains the following properties:

pom.xml generated using project archetype
  <properties>
    <magnoliaVersion>4.4.2</magnoliaVersion>
    <stkVersion>1.4.2</stkVersion>
    <javaVersion>1.5</javaVersion>
  </properties>

Whereas, the pom.xml file that gets generated when using the stk-theme archetype contains the following properties:

pom.xml generated using stk-theme archetype
  <properties>
    <magnoliaVersion>4.4.2</magnoliaVersion>
    <magnoliaSTKVersion>1.4.2</magnoliaSTKVersion>
  </properties>

Note: stkVersion is define by one, and magnoliaSTKVersion is defined by the other.

Additionally, the javaVersion property is defined in the project pom, but in the pom.xml file that's generated by the module archetype, the values are hard-coded within the compiler plugin configuration:

pom.xml generated using module archetype
  <build>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-compiler-plugin</artifactId>
        <version>2.3.2</version>
        <configuration>
          <source>1.6</source>
          <target>1.6</target>
        </configuration>
      </plugin>
    </plugins>
    ...
  </build>

Please let me know if you have any questions.

Thanks,
Matt


Generated at Sun Feb 11 23:22:42 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.