[BLOSSOM-12] "autodetected" dialog created with "mgnl:content" type. Created: 09/Sep/10  Updated: 06/Dec/14  Resolved: 10/Sep/10

Status: Closed
Project: Blossom
Component/s: None
Affects Version/s: 1.1
Fix Version/s: 1.1.1

Type: Bug Priority: Minor
Reporter: Danilo Ghirardelli Assignee: Tobias Mattsson
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Sometimes using blossom this log appears:

WARN info.magnolia.module.admininterface.DialogHandlerManager.onRegister(DialogHandlerManager.java:95) Dialog definitions should be of type contentNode but [/modules/blossom/dialogs/autodetected] is of type content.

The problem is that DefaultBlossomParagraphRegistry calls RepositoryUtils.createEmptyConfigNode(PARAGRAPHS_PATH), and that method creates a node of type content, but now dialog nodes are required to be of contentNode type. Maybe it would be better to call that method to create all the required parent contents and only then create the last contentNode.



 Comments   
Comment by Tobias Mattsson [ 09/Sep/10 ]

The problem occurs only when there are no blossom managed dialogs registered. The autodetected node then has no children and is incorrectly considered as a dialog config node of its own. In fact its even registered as a dialog with the name 'autodetected' and will use the default ConfiguredDialog as its dialog handler.

The solution would have to make sure that the autodetected node exists if it has no child nodes. That is, it should be removed on startup and created only when needed. Currently it is removed and recreated on startup.

Comment by Tobias Mattsson [ 10/Sep/10 ]

The autodectected node is now deleted on startup and created on demand when needed.

Comment by Tobias Mattsson [ 10/Sep/10 ]

Fix applies to templates and paragraphs too.

Comment by Jan Haderka [ 06/Dec/14 ]

Bulk close of old resolved issues.

Generated at Sun Feb 11 23:29:14 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.