[BLOSSOM-149] Parameter mgnlChannel is appended to query string with ? Created: 29/Oct/13  Updated: 04/Nov/13  Resolved: 04/Nov/13

Status: Closed
Project: Blossom
Component/s: None
Affects Version/s: 3.0
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Sigurd Rolfes Assignee: Tobias Mattsson
Resolution: Duplicate Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Windows 7
Apache Tomcat 7.0.42
Spring MVC 3.2.3
Spring Webflow 2.3.2


Issue Links:
duplicate
duplicates MGNLUI-2348 Pages with request parameters break i... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

To resume a webflow creating links like this should be possible:

http://localhost:18080/CONTEXT/Startseite/Shop.html?execution=e3s6&_eventId=drawDate

Magnolia appends a parameter with ? to the query string:

http://localhost:18080/CONTEXT/Startseite/Shop.html?execution=e3s6&_eventId=drawDate?mgnlChannel=desktop

This results in a wrong flow transition "drawDate?mgnlChannel=desktop", because "?" should be "&", see stacktrace below.

Same problem with preexecution key _pecid:

2013-10-29 12:59:13,654 ERROR magnolia.module.blossom.preexecution.BlossomFilter: Content for pre-execution [e1a48f1e-3888-4675-80ff-0eea2db20a45?mgnlChannel=desktop] not found in repository

########################################################

Stacktrace:

Caused by: org.springframework.webflow.engine.NoMatchingTransitionException: No transition found on occurence of event 'drawDate?mgnlChannel=desktop' in state 'orderOverview' of flow 'shop-flow' – valid transitional criteria are array<TransitionCriteria>[next, back] – likely programmer error, check the set of TransitionCriteria for this state
at org.springframework.webflow.engine.TransitionableState.getRequiredTransition(TransitionableState.java:93)
at org.springframework.webflow.engine.TransitionableState.handleEvent(TransitionableState.java:119)
at org.springframework.webflow.engine.Flow.handleEvent(Flow.java:555)
at org.springframework.webflow.engine.impl.FlowExecutionImpl.handleEvent(FlowExecutionImpl.java:388)
at org.springframework.webflow.engine.impl.RequestControlContextImpl.handleEvent(RequestControlContextImpl.java:210)
at org.springframework.webflow.engine.ViewState.handleEvent(ViewState.java:232)
at org.springframework.webflow.engine.ViewState.resume(ViewState.java:196)
at org.springframework.webflow.engine.Flow.resume(Flow.java:545)
at org.springframework.webflow.engine.impl.FlowExecutionImpl.resume(FlowExecutionImpl.java:258)
at org.springframework.webflow.executor.FlowExecutorImpl.resumeExecution(FlowExecutorImpl.java:169)
at org.springframework.webflow.mvc.servlet.FlowHandlerAdapter.handle(FlowHandlerAdapter.java:183)
at org.springframework.webflow.mvc.servlet.FlowController.handleRequest(FlowController.java:174)
at de.aktionmensch.components.ShopFlow.handleRequest(ShopFlow.java:51)
at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:48)
at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:925)
at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:856)
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:936)
... 179 more



 Comments   
Comment by Sigurd Rolfes [ 29/Oct/13 ]

This is the complete query string read from the request in my blossom component:

QueryString [execution=e4s6&_eventId=drawDate?mgnlChannel=desktop&mgnlPreview=true]

Comment by Sigurd Rolfes [ 30/Oct/13 ]

I think the cause itself is not Blossom related.

There should be a check on parameters (query string), if parameters are provided the mgnl stuff should be appended with & instead of ?.

Is anyone working on this? We need the process navigation inside our webflow working.

Sigurd

Generated at Sun Feb 11 23:30:37 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.