[BLOSSOM-178] Add exposeModelAttributes property on UuidRedirectViewResolver Created: 27/Jun/14 Updated: 08/Dec/14 Resolved: 25/Jul/14 |
|
| Status: | Closed |
| Project: | Blossom |
| Component/s: | None |
| Affects Version/s: | 2.0.3, 3.0 |
| Fix Version/s: | 2.0.6, 3.0.3 |
| Type: | Improvement | Priority: | Critical |
| Reporter: | Jean-Charles Robert | Assignee: | Tobias Mattsson |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Magnolia 4.5.11 |
||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Patch included: |
Yes
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
We have the possibility in the Spring ViewResolver to set the attribute "exposeModelAttributes". When false, this will avoid to pass the model attributes to the request and when redirect have ugly string parameters visible in the url. In blossom, this option solves a big performance problem. I added this functionality by extending the UuidRedirectViewResolver in order to expose the "exposeModelAttributes" variable. (See java file attached) blossom-servlet.xml <bean class="com.aperto.bos.blossom.BosUuidRedirectViewResolver"> <property name="order" value="1" /> <property name="exposeModelAttributes" value="false" /> </bean> Reason is: The parameters in url cause a huge performance problem. |
| Comments |
| Comment by Tobias Mattsson [ 04/Jul/14 ] |
|
Hi Jean-Charles, Do you have any further details on the performance problems? I'd be very interested to find out what's causing this. The parameters should mean no extra processing as they're carried along from controller to controller in the request object. |
| Comment by Jean-Charles Robert [ 10/Jul/14 ] |
|
Hello Tobias, I tried to research and it has maybe something to do with the "SpecialAttributeRequestWrapper".
See in attachment 2 of the thread reports. |
| Comment by Jean-Charles Robert [ 25/Jul/14 ] |
|
Hi Tobias, |
| Comment by Tobias Mattsson [ 25/Jul/14 ] |
|
I've created |