[BLOSSOM-256] Adapt Blossom module for Magnolia 6 Created: 03/Jul/19 Updated: 03/Apr/20 Resolved: 22/Aug/19 |
|
| Status: | Closed |
| Project: | Blossom |
| Component/s: | None |
| Affects Version/s: | 3.2.1 |
| Fix Version/s: | 3.3 |
| Type: | Bug | Priority: | Blocker |
| Reporter: | Tom Trapp | Assignee: | Robert Šiška |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Patch included: |
Yes
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Epic Link: | Support | ||||||||||||
| Sprint: | SPA Editor 4 | ||||||||||||
| Story Points: | 3 | ||||||||||||
| Description |
|
I've updated my running magnolia instance from 6.0 to 6.1 without updates to blossom (using 3.2.1). I'm getting the following error when opening a dialog or pageproperties -> magnolia_blossom_error.txt This is caused due to a signature change in the code which came with Magnolia 6.1.
Solutions: Replace the existing constructor with the new new constructor in the following code in the class BlossomFormDialogPresenter. @Inject public BlossomFormDialogPresenter(DialogDefinitionRegistry dialogDefinitionRegistry, FormBuilder formBuilder, ComponentProvider componentProvider, DialogActionExecutor executor, FormView view, I18nizer i18nizer, SimpleTranslator i18n) { super(dialogDefinitionRegistry, formBuilder, componentProvider, executor, view, i18nizer, i18n); this.dialogDefinitionRegistry = dialogDefinitionRegistry; } |
| Comments |
| Comment by Tom Trapp [ 03/Jul/19 ] |
|
Patch with the solutions attached -> BLOSSOM-256_patch.diff |
| Comment by Simon Lutz [ 03/Jul/19 ] |
|
Hi tom_trapp, thanks a lot for sharing your findings and patch. We will look into this. Cheers, |
| Comment by Tom Trapp [ 22/Aug/19 ] |
|
Nice, Thanks! |