[BLOSSOM-257] Blossom update for 6.2 Created: 27/Aug/19  Updated: 29/Jun/20  Resolved: 16/Apr/20

Status: Closed
Project: Blossom
Component/s: None
Affects Version/s: None
Fix Version/s: 3.4

Type: Improvement Priority: Neutral
Reporter: Simon Lutz Assignee: Sang Ngo Huu
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: 0d
Time Spent: 3h
Original Estimate: Not Specified

Attachments: PNG File blossom-text-dialog.png    
Issue Links:
Cloners
is cloned by BLOSSOM-276 Support Node parameter injection in 6... Closed
Relates
dependency
is depended upon by BLOSSOM-265 DOC: Update Blossom release page for ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: UI framework: advanced features
Sprint: 6.2.1 Ramp-up 22
Story Points: 1

 Description   

BLOSSOM-256 brought Blossom back for M6.1; the goal of this ticket is to adapt it to M6.2:

  • Do not use the compatibility layer
  • Use the new dialogs as of M6.2


 Comments   
Comment by Mikaël Geljić [ 03/Apr/20 ]

Truth is the compatibility layer doesn't work

  1. Former info.magnolia.ui.dialog.definition.DialogDefinitionRegistry was "unbound" from configured components—could have used a retrofitting adapter—so annotated templates and dialog factories don't work.
  2. Once naively migrated to the newer interfaces—but still registering old-style compatibility dialogs for good measure—dialogs open up empty, no control, no button, no stack trace.
Comment by Mikaël Geljić [ 11/Jun/20 ]

What was done in 3.4:

  • use the new `DialogDefinitionRegistry`
  • but keep registering old-style compatibility dialogs (rely on auto-conversion for the new Pages app).

This maintained status quo in the compatibility Pages app (+/- BLOSSOM-269, fixed in 3.4.1).

This introduced support for *simple* dialog/tab-factories in new Pages app.
However there, there are still certain objects that the old BlossomFormDialogPresenter used to make injectable, mostly Vaadin 7 Item, JCR Node and node path. These use cases must keep using the compatibility Pages app for the time being. Magnolia 6 UI Framework does not have configurable form-dialog presenters, nor Vaadin 7 Items.

Generated at Sun Feb 11 23:31:42 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.