[BLOSSOM-258] Blossom dialogs broken on 6.1.x DX Core but 6.1 Community works fine Created: 17/Dec/19  Updated: 15/Apr/20  Resolved: 15/Apr/20

Status: Closed
Project: Blossom
Component/s: None
Affects Version/s: 3.3
Fix Version/s: None

Type: Bug Priority: Critical
Reporter: Edwin Guilbert Assignee: Unassigned
Resolution: Workaround exists Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Magnolia 6.1.3 DX Core


Attachments: PNG File community-blossom component.png     PNG File dxcore-blossom-component.png     Text File error.log    
Issue Links:
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

When registering a simple blossom component on Magnolia 6.1.3 DX Core, dialogs are broken.

The component can be registered and added to a page without problems. But when trying to modify it the edit component action throws the following exception:

java.lang.ClassCastException: info.magnolia.module.blossom.dialog.BlossomFormDialogPresenter cannot be cast to info.magnolia.personalization.ui.pages.dialog.ElementAwareFormDialogPresenter

Full stacktrace log is attached.

When trying the same blossom component on Magnolia 6.1.3 Community the dialog shows just fine and the component can be edited without any issues. (Probably because the community bundle doesn't have personalization modules installed).

The sample module used to test this issue can be found here:

https://github.com/ebguilbert/cart-blossom

The steps to reproduce the issue are:

  1. Create a basic template page
  2. Add cart blossom component to the footer area
  3. Fill-in the dialog and save.
  4. Try to edit the component.

 

Screenshots for community working and DX Core not working are also attached.



 Comments   
Comment by Roman Kovařík [ 18/Dec/19 ]

Do you have personalization-blossom installed?

Comment by Edwin Guilbert [ 18/Dec/19 ]

No I don't have it installed.

I tested the following setup:

 

    <dependency>
      <groupId>info.magnolia.dx</groupId>
      <artifactId>magnolia-dx-core-webapp</artifactId>
      <type>war</type>
    </dependency>
    <dependency>
      <groupId>info.magnolia.dx</groupId>
      <artifactId>magnolia-dx-core-webapp</artifactId>
      <type>pom</type>
    </dependency>
   <dependency>
      <groupId>openexpo.magnolia</groupId>
      <artifactId>cart-blossom</artifactId>
   <version>1.0-SNAPSHOT</version>
   </dependency>

and the cart-blossom module dependencies are:

    <dependency>
      <groupId>info.magnolia.blossom</groupId>
      <artifactId>magnolia-module-blossom</artifactId>
      <version>3.3</version>
    </dependency>
    <dependency>
      <groupId>org.springframework</groupId>
      <artifactId>spring-webmvc</artifactId>
      <version>5.1.9.RELEASE</version>
      <exclusions>
        <exclusion>
          <groupId>commons-logging</groupId>
          <artifactId>commons-logging</artifactId>
        </exclusion>
      </exclusions>
    </dependency>
    <dependency>
      <groupId>org.springframework</groupId>
      <artifactId>spring-aop</artifactId>
      <version>5.1.9.RELEASE</version>
      <exclusions>
        <exclusion>
          <groupId>commons-logging</groupId>
          <artifactId>commons-logging</artifactId>
        </exclusion>
      </exclusions>
    </dependency>

Full pom: https://github.com/ebguilbert/cart-blossom/blob/master/pom.xml

 

Comment by Edwin Guilbert [ 18/Dec/19 ]

Tried adding the personalization-blossom dependency and the component works fine with DX Core 6.1.3

<dependency>
   <dependency>
   <groupId>info.magnolia.personalization</groupId>
   <artifactId>magnolia-personalization-blossom</artifactId>
   <version>1.8</version>
 </dependency> 

Maybe a reference to personalization-blossom should be added to the documentation wiki since I was not aware that this was needed for latest non-community versions of Magnolia.

Otherwise the ticket can be closed since the issue is solved.

Generated at Sun Feb 11 23:31:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.