[BLOSSOM-267] Harmonize the definition logging for Blossom Created: 11/May/20  Updated: 10/Jun/20  Resolved: 10/Jun/20

Status: Closed
Project: Blossom
Component/s: None
Affects Version/s: 3.3.1
Fix Version/s: 3.4.1

Type: Improvement Priority: Minor
Reporter: Richard Gange Assignee: Mikaël Geljić
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to BLOSSOM-261 SiteAwareFreemarkerRenderer reference... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

In BLOSSOM-261 we changed the logging for DialogExporter from DEBUG level to INFO level.

Let's also change it in:

  • Template Exporter
  • VirtualURIMappingExporter

One more suggestion, I think we can remove the check to see if it's "turned on":

// current
if (logger.isInfoEnabled()) {
   logger.info("Registered dialog [" + dialogDescription.getId() + "]");

// changed
logger.info("Registered dialog [" + dialogDescription.getId() + "]");

It would also be nice (but not required) if it looked closer to how YAML definitions work. There is a lot more information provided.

2020-05-11 12:54:22,134 INFO  agnolia.config.source.yaml.YamlConfigurationSource: Registered definition from YAML file [/mtk/dialogs/components/html.yaml]: [dialog] definition [html] with reference id: [mtk:components/html] from module [mtk] at [components/html]


 Comments   
Comment by Richard Gange [ 11/May/20 ]

Examples:

[INFO] Running info.magnolia.module.blossom.urimapping.BlossomVirtualURIMapperTest
2020-05-11 20:33:42,666 INFO  odule.blossom.urimapping.VirtualURIMappingExporter: Registered virtualURIMapping from blossom [info.magnolia.module.blossom.urimapping.MockVirtualURIMapping#0]
2020-05-11 20:33:42,667 INFO  odule.blossom.urimapping.VirtualURIMappingExporter: Registered virtualURIMapping from blossom [info.magnolia.module.blossom.urimapping.BlossomVirtualURIMapperTest$IncorrectURIMapping#0]

[INFO] Running info.magnolia.module.blossom.template.TemplateExporterTest
2020-05-11 20:33:43,696 INFO  .magnolia.module.blossom.template.TemplateExporter: Registered definition from blossom [info.magnolia.module.blossom.template.TemplateExporterTest$TestTemplate]: [template] definition [TestTemplate] with reference id: [module:TestTemplate] from module [module] at [TestTemplate]

2020-05-11 20:33:43,722 INFO  .magnolia.module.blossom.template.TemplateExporter: Registered definition from blossom [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithAreaWithPreRegisterCallbackThatReturnsNull]: [template] definition [TemplateWithAreaWithPreRegisterCallbackThatReturnsNull] with reference id: [module:TemplateWithAreaWithPreRegisterCallbackThatReturnsNull] from module [module] at [TemplateWithAreaWithPreRegisterCallbackThatReturnsNull]

2020-05-11 20:33:43,735 INFO  .magnolia.module.blossom.template.TemplateExporter: Registered definition from blossom [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithPreRegisterCallbacks]: [template] definition [TemplateWithPreRegisterCallbacks] with reference id: [module:TemplateWithPreRegisterCallbacks] from module [module] at [TemplateWithPreRegisterCallbacks]

2020-05-11 20:33:43,743 INFO  .magnolia.module.blossom.template.TemplateExporter: Registered definition from blossom [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithPreRegisterCallbacks]: [dialog] definition [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithPreRegisterCallbacks] with reference id: [blossom-template-dialog:info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithPreRegisterCallbacks] from module [blossom-template-dialog] at [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithPreRegisterCallbacks]

2020-05-11 20:33:43,744 INFO  .magnolia.module.blossom.template.TemplateExporter: Registered definition from blossom [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithPreRegisterCallbacks$TestArea]: [dialog] definition [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithPreRegisterCallbacks$TestArea] with reference id: [blossom-area-dialog:info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithPreRegisterCallbacks$TestArea] from module [blossom-area-dialog] at [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithPreRegisterCallbacks$TestArea]

2020-05-11 20:33:43,755 INFO  .magnolia.module.blossom.template.TemplateExporter: Registered definition from blossom [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithDialogFields]: [template] definition [TemplateWithDialogFields] with reference id: [module:TemplateWithDialogFields] from module [module] at [TemplateWithDialogFields]

2020-05-11 20:33:43,756 INFO  .magnolia.module.blossom.template.TemplateExporter: Registered definition from blossom [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithDialogFields]: [dialog] definition [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithDialogFields] with reference id: [blossom-template-dialog:info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithDialogFields] from module [blossom-template-dialog] at [info.magnolia.module.blossom.template.TemplateExporterTest$TemplateWithDialogFields]

2020-05-11 20:33:44,347 INFO  .magnolia.module.blossom.template.TemplateExporter: Registered definition from blossom [info.magnolia.module.blossom.template.ComponentCategoryAnnotationTest$TestTemplate]: [template] definition [testTemplate] with reference id: [myModule:pages/testTemplate] from module [myModule] at [pages/testTemplate]

2020-05-11 20:33:44,348 INFO  .magnolia.module.blossom.template.TemplateExporter: Registered definition from blossom [info.magnolia.module.blossom.template.ComponentCategoryAnnotationTest$TestComponent]: [template] definition [testComponent] with reference id: [myModule:components/testComponent] from module [myModule] at [components/testComponent]

2020-05-11 20:33:44,376 INFO  agnolia.module.blossom.dialog.DialogExporterTest$1: Registered definition from blossom [info.magnolia.module.blossom.dialog.DialogExporterTest$TestDialogFactory]: [dialog] definition [TestDialogFactory] with reference id: [module:TestDialogFactory] from module [module] at [TestDialogFactory]

2020-05-11 20:33:44,410 INFO  agnolia.module.blossom.dialog.DialogExporterTest$1: Registered definition from blossom [info.magnolia.module.blossom.dialog.DialogExporterTest$DialogFactoryWithPreRegisterCallback]: [dialog] definition [DialogFactoryWithPreRegisterCallback] with reference id: [module:DialogFactoryWithPreRegisterCallback] from module [module] at [DialogFactoryWithPreRegisterCallback]

2020-05-11 20:33:44,422 INFO  agnolia.module.blossom.dialog.DialogExporterTest$1: Registered definition from blossom [info.magnolia.module.blossom.dialog.DialogExporterTest$DialogFactoryWithOverriddenPreRegisterCallback]: [dialog] definition [DialogFactoryWithOverriddenPreRegisterCallback] with reference id: [module:DialogFactoryWithOverriddenPreRegisterCallback] from module [module] at [DialogFactoryWithOverriddenPreRegisterCallback]

2020-05-11 20:33:44,431 INFO  agnolia.module.blossom.dialog.DialogExporterTest$1: Registered definition from blossom []: [dialog] definition [DialogFactoryWithPreRegisterThatAddsMessageToMessageFromSuperclass] with reference id: [module:DialogFactoryWithPreRegisterThatAddsMessageToMessageFromSuperclass] from module [module] at [DialogFactoryWithPreRegisterThatAddsMessageToMessageFromSuperclass]
Generated at Sun Feb 11 23:31:47 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.