[BUILD-1113] core.Jenkins pipeline-templates integrationTestsPipeline, moduleUiTestsPipeline w/ additional param Created: 28/Jul/23  Updated: 16/Aug/23  Resolved: 02/Aug/23

Status: Closed
Project: Build
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Christoph Meier Assignee: Christoph Meier
Resolution: Resolved Votes: 0
Labels: VN-Testing
Remaining Estimate: Not Specified
Time Spent: 7h
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Work Started:

 Description   

For MGNLTEST-425 - we should be able to set env.variable in Jenkinsfile

to set selenium.standalone=false - in case we use a hub
see https://git.magnolia-cms.com/projects/PLATFORM/repos/test-framework/browse/magnolia-test-framework/src/main/java/info/magnolia/test/setup/IntegrationTestSettings.java#89-91 

Since core.jenkins is using templates - we should adapt the template integrationTestsPipeline.

option 1: Add one new parameter
option2: Extend the API of this template allowing to set name-value-pairs



 Comments   
Comment by Christoph Meier [ 02/Aug/23 ]

Reviewed w/ Duy (1st part).
Reviewed again w/ Maxime.
After hat, integrated final part

Comment by Christoph Meier [ 02/Aug/23 ]

Next time, when creating a PR on this project, no need to directly merge.
These templates can stay as PR an can be called by projects.

Add the snippet on top of the Jenkinsfile where we call the template. 1st line points to PR

@Library('pipeline-templates@feature/my-new-pr') _
integrationTestsPipeline(
integrationTestsModulePath: 'magnolia-integration-tests',
dockerContextPath: 'magnolia-integration-tests',
magnoliaImageTag: 'mgnl/test-tomcat-ce:1.0',
canonicalImagePath: 'magnolia-community-webapp',
seleniumHub: true,
jdk: 'JDK17')
Generated at Sun Feb 11 23:48:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.