[BUILD-124] Skipping Clover on releases does not work on submodules of a reactor build Created: 13/Jun/13 Updated: 08/May/15 Resolved: 18/Mar/15 |
|
| Status: | Closed |
| Project: | Build |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | POMs 31 |
| Type: | Bug | Priority: | Major |
| Reporter: | Magnolia International | Assignee: | Magnolia International |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||
| Template: |
|
||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||
| Description |
|
Removing enable-clover from the <additionalReleaseProfiles> property only works if set at the parent level of a reactor build. Setting it in a submodule has no effect - the release-plugin is already configured ! |
| Comments |
| Comment by Magnolia International [ 13/Jun/13 ] |
|
One way to work around this is to add the following snippet in the submodule. It's a little too verbose to my taste, is inconsistent, and .. does it really work ?
<build>
<pluginManagement>
<plugins>
<plugin>
<!-- We're doing this here because the trick implemented for BUILD-110 actually does not work with submodules of reactors. See BUILD-124. -->
<groupId>com.atlassian.maven.plugins</groupId>
<artifactId>maven-clover2-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
|
| Comment by Magnolia International [ 16/Mar/15 ] |
|
We could introduce a property to control clover's skip property, but the problem i see is that this doesn't completely skip Clover anyway - it skips instrumentation, but the forked lifecycle is still execution, which IMO causes more confusion. See https://jira.atlassian.com/browse/CLOV-1670 |
| Comment by Magnolia International [ 18/Mar/15 ] |
|
You can now skip Clover by setting the skipClover property to true. Note that this will skip it for all builds, not just releases. Also note that, contrary to the profile technique used in |