[BUILD-154] Remove m2e lifecycle mapping - now irrelevant Created: 16/Oct/14  Updated: 13/Apr/17  Resolved: 23/Oct/14

Status: Closed
Project: Build
Component/s: None
Affects Version/s: None
Fix Version/s: POMs 30

Type: Improvement Priority: Neutral
Reporter: Federico Grilli Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File eclipse-ignore-m2e-issue.png    
Issue Links:
relation
is related to BUILD-181 Provide m2e lifecycle for our own plu... Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

Looks like we can remove this rather verbose config from our parent poms:
http://wiki.eclipse.org/M2E_plugin_execution_not_covered#lifecycle_mapping_metadata_provided_by_maven_plugin
http://wiki.eclipse.org/M2E_plugin_execution_not_covered#eclipse_workspace_lifecycle_mapping_metadata



 Comments   
Comment by Magnolia International [ 16/Oct/14 ]

Config now removed, but I suspect we'll either need to update our own plugin to provide the lifecycle mapping to m2e (please do feel free to investigate on how to do this and patch the plugins !), and we'll need to update versions of a bunch of other plugins, but that's on the radar for poms 30 anyway. If you get a chance please test latest snapshots. ((!)groupIDs changed to info.magnolia.maven.poms, i.m.m.poms-enterprise, etc.)

Comment by Federico Grilli [ 17/Oct/14 ]

OK, just tested the new POM with

  • Eclipse (Version: Luna Service Release 1 (4.4.1))
  • Parent POM
          <groupId>info.magnolia.maven.poms</groupId>
          <artifactId>magnolia-parent-pom-community</artifactId>
          <version>30-SNAPSHOT</version>
    

    and the IDE uttered the following

    Multiple annotations found at this line:
    - maven-enforcer-plugin (goal "enforce") is ignored by m2e.
    - Plugin execution not covered by lifecycle configuration: info.magnolia.maven.plugins:magnolia-setproperty-maven-plugin:1.2:set-property (execution: currentDate, phase: generate-resources)
    - maven-remote-resources-plugin (goal "process") is ignored by m2e. 
    

    So two ignores (maven-remote-resources-plugin + maven-enforcer-plugin) and one "error" (our magnolia-setproperty-maven-plugin). For the latter it sufficed to choose the fix option "Mark goal as ignored ... in Eclipse preferences" which should be available since Eclipse 4.2 and avoids cluttering the pom with eclipse-specific config. In the attached screenshots you can see the "issue" being an error icon next to the pom's parent tag. By choosing the above-mentioned option I got rid of it. As far as I'm concerned, this is more than acceptable and can be resolved.

Comment by Magnolia International [ 23/Oct/14 ]

Added m2e lifecycle mappings to our plugins (BUILD-181) and removed m2e config from our parent pom. Some plugins are still causing warnings (gmaven for example), but since those weren't configured previously, the warnings aren't new and presumably don't cause any real issue.

Generated at Sun Feb 11 23:39:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.