[BUILD-182] Review/remove our Maven plugins Created: 23/Oct/14  Updated: 29/Nov/22

Status: Accepted
Project: Build
Component/s: Maven Plugins
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Magnolia International Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to BUILD-162 Reconsider list of reports generated ... Accepted
relates to MGNLCE-40 Replace tomcat download via bundle pl... Closed
relates to MGNLEE-440 CLONE - Replace tomcat download via b... Closed
relates to MPBUN-9 Rename maven-bundle-plugin to somethi... Closed
dependency
depends upon BUILD-148 Merge build-tools with poms lifecycle Closed
Template:
Acceptance criteria:
Empty
Release notes required:
Yes
Date of First Response:
Team: Foundation

 Description   

We currently have 2 maven plugins. Below is a list of what they do, how we use them, and possible replacement/changes.

  • info.magnolia:maven-bundle-plugin has 4 mojos:
    • bootstrap - used to process bootstrap files. Unused. Don't think it'll ever be, or would probably be rewritten.
    • bundle - was used to create war files ? Unused.
    • tomcat - was used to download Tomcat and package bundles. Unused.
    • download - can download and unpack any arbitrary URL but only ever used to download and untar Tomcat in the -bundle projects.
      • Could be replaced by a combination of wagon:download-single and truezip:copy (which, like its name doesn't indicate, it supposed to deal with all sorts of archive formats, including tgz)
  • info.magnolia.maven.plugins:magnolia-setproperty-maven-plugin has 1 mojo which we use to set 4 properties.


 Comments   
Comment by Mikaël Geljić [ 26/May/16 ]
  • download - can download and unpack any arbitrary URL but only ever used to download and untar Tomcat in the -bundle projects.
    • Could be replaced by a combination of wagon:download-single and truezip:copy (which, like its name doesn't indicate, it supposed to deal with all sorts of archive formats, including tgz)

Also dependency:copy, or even better dependency:unpack; we're giving it a go, especially since https://archive.apache.org was down intermittently (and tomcat releases are on central for a little while as well)

Comment by Mikaël Geljić [ 27/Mar/20 ]

Update 2020:

  • magnolia-bundle-maven-plugin: not used anymore, has been superseded by the tomcat-barebone project (MGNLTOMCAT).
    • Tomcat bundles are produced from webapp artifacts, see MGNLCE-128 and MGNLEE-536.
    • or assembled directly on clients' CLI when using the Magnolia Jumpstart
  • magnolia-setproperty-maven-plugin apparently does not support Maven's incremental build capabilities; its various purposes should be replaced by Maven CI-Friendly versions, resource filtering and the build-helper plugin where applicable.
Comment by Maxime Michel [ 29/Nov/22 ]

After a look at the project's issues and PR's in the last couple of years (maintainer doesn't invest any time), I think we can safely exclude the following from being a possible option:

magnoliaNiceVersion, which is set through info.magnolia.maven.setproperty.VersionNameValueProvider could perhaps be contributed to the Mojo project, since its build-helper plugin already produces a couple of similar properties.

Generated at Sun Feb 11 23:39:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.