[BUILD-203] Bypass checkstyle for all generated sources Created: 15/Apr/15  Updated: 07/May/15  Resolved: 15/Apr/15

Status: Closed
Project: Build
Component/s: Build Tools, Poms
Affects Version/s: None
Fix Version/s: Build Resources 1.6.1, POMs 31

Type: Improvement Priority: Neutral
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty

 Description   

We currently bypass checkstyle for clover-generated sources, but we probably want to bypass it for all.
Leave this open for now because it's debatable. Tools like APT don't always let us hook in to add our license headers and such, but maybe we should actually fix that instead of bypassing.

If we want it, this patch does the trick:

iff --git a/build-resources/src/main/resources/magnolia-build-resources/checkstyle-suppressions.xml b/build-resources/src/main/resources/magnolia-build-resources/checkstyle-suppressions.xml
index 4b92104..faa6bcc 100644
--- a/build-resources/src/main/resources/magnolia-build-resources/checkstyle-suppressions.xml
+++ b/build-resources/src/main/resources/magnolia-build-resources/checkstyle-suppressions.xml
@@ -9,4 +9,7 @@
   <suppress files="src/test/.*" checks="JavadocStyle"/>
   <!-- Excluding Clover-generated sources - See BUILD-57 -->
   <suppress files="target/clover/.*" checks=".*"/>
+  <!-- Excluding other generated sources -->
+  <suppress files="target/generated-(test-)?sources/.*" checks=".*"/>
+
 </suppressions>


 Comments   
Comment by Magnolia International [ 15/Apr/15 ]

Done as per patch

Comment by Magnolia International [ 07/May/15 ]

Duh. Was still using previous version of build-resources in poms, so this never got propagated to our projects.

Generated at Sun Feb 11 23:39:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.