[BUILD-204] Test classes are compiled twice Created: 15/Apr/15  Updated: 04/May/15  Resolved: 15/Apr/15

Status: Closed
Project: Build
Component/s: Poms
Affects Version/s: None
Fix Version/s: POMs 31

Type: Bug Priority: Neutral
Reporter: Magnolia International Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty

 Description   

For some reason, it looks we're compiling test classes twice. Here's an edited excerpt of a build:

[INFO] --- maven-resources-plugin:2.7:resources (default-resources) @ magnolia-resource-loader ---
[...]
[INFO] --- maven-compiler-plugin:3.2:compile (default-compile) @ magnolia-resource-loader ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 25 source files to /Users/gjoseph/Dev/magnolia/git/magnolia_main-clean-2/magnolia-resource-loader/target/classes
[...]
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (compile-tests) @ magnolia-resource-loader ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 11 source files to /Users/gjoseph/Dev/magnolia/git/magnolia_main-clean-2/magnolia-resource-loader/target/test-classes
^--- first testCompile
[...]
[INFO] --- maven-resources-plugin:2.7:testResources (default-testResources) @ magnolia-resource-loader ---
[...]
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ magnolia-resource-loader ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 11 source files to /Users/gjoseph/Dev/magnolia/git/magnolia_main-clean-2/magnolia-resource-loader/target/test-classes
^--- second testCompile !
[...]
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ magnolia-resource-loader ---

At first sight, it'd look like the first compile is with a custom execution of the plugin that we do, while the second one uses the default-testCompile execution.



 Comments   
Comment by Magnolia International [ 15/Apr/15 ]

This appears to be the case since at least MAGNOLIA-2345. That would seem to indicate we haven't relied on the javaVersionForTest property all that much. (as far as I can tell the 2nd compile ignores it)
edit: confirmed, it doesn't work. If one sets javaVersionForTest to 1.8 (and use eg lambdas in a test), the 2nd compile phase fails.

Generated at Sun Feb 11 23:39:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.