[BUILD-218] Provide new/custom signatures for java 1.8 and org.codehaus.mojo:animal-sniffer-maven-plugin Created: 15/Dec/15  Updated: 15/Apr/16  Resolved: 21/Feb/16

Status: Closed
Project: Build
Component/s: Build Tools, Poms
Affects Version/s: POMs 31
Fix Version/s: None

Type: Task Priority: Major
Reporter: Philip Mundt Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to BUILD-198 Use Animal Sniffer to make sure we do... Closed
dependency
is depended upon by ARCH-48 Update 'magnolia-forge-module-archety... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: Make build system Java 8 ready

 Description   

We use and configure the plugin org.codehaus.mojo:animal-sniffer-maven-plugin in info.magnolia.maven.poms:magnolia-parent-pom but unfortunately the signatures for java 1.8 are not available yet.

This results in the following error when compiling any module that uses our parent poms + set java version to 1.8:

[ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.14:check (check-java-api-compatibility) on project test-forge-module: Failed to obtain signature: org.codehaus.mojo.signature:java18:1.0: Could not find artifact org.codehaus.mojo.signature:java18:signature:1.0 in magnolia.nexus (https://nexus.magnolia-cms.com/content/groups/staff)
Temporary workaround

Build the respective module using -Danimal.sniffer.skip



 Comments   
Comment by Mikaël Geljić [ 16/Dec/15 ]

Alternatively, we could (temporarily) skip it in generated pom as well, with a nice inline comment

<pluginManagement>
  <plugins>
    <plugin>
      <groupId>org.codehaus.mojo</groupId>
      <artifactId>animal-sniffer-maven-plugin</artifactId>
      <configuration>
        <skip>true</skip>
      </configuration>
    </plugin>
  </plugins>
</pluginManagement>
Comment by Philip Mundt [ 21/Feb/16 ]

Sugnatures are now available (see https://github.com/mojohaus/animal-sniffer/issues/1).

When setting javaVersion=1.8 the correct signatures are found and downloaded:

[INFO] --- animal-sniffer-maven-plugin:1.14:check (check-java-api-compatibility) @ magnolia-project ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java18:1.0
Downloading: https://nexus.magnolia-cms.com/content/groups/staff/org/codehaus/mojo/signature/java18/1.0/java18-1.0.signature
Downloaded: https://nexus.magnolia-cms.com/content/groups/staff/org/codehaus/mojo/signature/java18/1.0/java18-1.0.signature (1956 KB at 1161.4 KB/sec)
Generated at Sun Feb 11 23:39:54 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.