[BUILD-261] Update Guava to version 23.1-jre from 18.0 Created: 02/Oct/17 Updated: 31/Oct/17 Resolved: 30/Oct/17 |
|
| Status: | Closed |
| Project: | Build |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | BOM 5.6 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Michael Mühlebach | Assignee: | Michael Mühlebach |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Epic Link: | Upgrade libraries for 5.6 | ||||||||||||||||
| Sprint: | Basel 116, Basel 119, Basel 120 | ||||||||||||||||
| Story Points: | 1 | ||||||||||||||||
| Description |
|
Important improvements:
|
| Comments |
| Comment by Philip Mundt [ 25/Oct/17 ] |
|
Please double check whether guava needs these dependencies to work otherwise add excludes for all of them: [INFO] | +- com.google.guava:guava:jar:23.1-jre:provided [INFO] | | +- com.google.code.findbugs:jsr305:jar:1.3.9:provided [INFO] | | +- com.google.errorprone:error_prone_annotations:jar:2.0.18:provided [INFO] | | +- com.google.j2objc:j2objc-annotations:jar:1.1:provided [INFO] | | \- org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:provided |
| Comment by Michael Mühlebach [ 26/Oct/17 ] |
|
Sorry didn't check for additional transitive dependencies. Findbugs is only used in the poms animal-sniffer-annotations provides an annotations which has retention=class. So we could basically exclude it because its not needed at runtime. j2obj-annotations provides annotations which all have retenation either source or class. So again not needed at runtime. errorprone-annotations has several runtime annotations therefore we need it. |
| Comment by Michael Mühlebach [ 30/Oct/17 ] |
|
see: https://git.magnolia-cms.com/projects/BUILD/repos/boms/pull-requests/42/overview |