[BUILD-305] Build autofactory on latest code to support java 9 Created: 15/May/18 Updated: 29/Oct/18 Resolved: 22/May/18 |
|
| Status: | Closed |
| Project: | Build |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Neutral |
| Reporter: | Sang Ngo Huu | Assignee: | Mikaël Geljić |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoR: |
Empty
|
| Date of First Response: | |
| Account: | |
| Epic Link: | Java 10 |
| Sprint: | Saigon 146 |
| Story Points: | 5 |
| Description |
|
Latest code of autofactory support Java 9 already but it is not released yet. So we can check license and build it then deploy to our nexus and wait until it is released. |
| Comments |
| Comment by Mikaël Geljić [ 15/May/18 ] |
License
|
| Comment by Mikaël Geljić [ 15/May/18 ] |
|
Mind dependency-trees too, although we use auto-factory as provided anyway. --- maven-dependency-plugin:2.8:tree (default-cli) @ auto-factory --- com.google.auto.factory:auto-factory:jar:0.1-beta1 +- com.google.auto.service:auto-service:jar:1.0-rc1:compile +- com.google.guava:guava:jar:16.0:compile +- com.squareup:javawriter:jar:2.4.0:compile +- com.squareup.dagger:dagger:jar:1.2.0:compile +- com.squareup.dagger:dagger-compiler:jar:1.2.0:compile +- javax.inject:javax.inject:jar:1:provided --- maven-dependency-plugin:2.8:tree (default-cli) @ auto-factory --- com.google.auto.factory:auto-factory:jar:HEAD-SNAPSHOT +- com.google.auto:auto-common:jar:0.10:compile +- com.google.auto.value:auto-value:jar:1.5.3:compile +- com.google.auto.service:auto-service:jar:1.0-rc4:provided +- com.google.googlejavaformat:google-java-format:jar:1.5:compile | \- com.google.errorprone:javac-shaded:jar:9-dev-r4023-3:compile +- com.google.guava:guava:jar:23.5-jre:compile | +- org.checkerframework:checker-qual:jar:2.0.0:compile | +- com.google.errorprone:error_prone_annotations:jar:2.0.18:compile | +- com.google.j2objc:j2objc-annotations:jar:1.1:compile | \- org.codehaus.mojo:animal-sniffer-annotations:jar:1.14:compile +- com.squareup:javapoet:jar:1.9.0:compile +- javax.inject:javax.inject:jar:1:compile |
| Comment by Mikaël Geljić [ 15/May/18 ] |
|
Re: Nexus, let's simply upload it manually (pom & jar) to the repository thirdparty (not available on central). Will build and deploy latest revision *within the factory sub-tree* (not interested in auto-value/common changes): 99af6e1 3 months ago Fix handling of @Generated in tests after 715b8eb, 0383c1c cushon Will tag this as 1.0-beta6-magnolia. EDIT: worth mentioning that required versions of auto-value, auto-common and auto-service are on maven central already. |
| Comment by Mikaël Geljić [ 15/May/18 ] |
|
sang.ngo In the end, I first deployed a SNAPSHOT to thirdparty.snapshots, for you to test as pre-int QA: <dependency> <groupId>com.google.auto.factory</groupId> <artifactId>auto-factory</artifactId> <version>1.0-beta6-magnolia-SNAPSHOT</version> </dependency> Let me know if everything's fine and I'll upload the actual release. |
| Comment by Mikaël Geljić [ 16/May/18 ] |
|
Release is now deployed to thirdparty repo (thus available for public group), with source and javadoc jars as well. <dependency> <groupId>com.google.auto.factory</groupId> <artifactId>auto-factory</artifactId> <version>1.0-beta6-magnolia</version> </dependency> |
| Comment by Mikaël Geljić [ 29/Oct/18 ] |
|
1.0-beta6 was released last week; now we should be able to discard our own patch-release |