[BUILD-86] NOTICE.txt contains wrong URLs Created: 17/Jan/12  Updated: 13/Apr/17  Resolved: 29/Jun/12

Status: Closed
Project: Build
Component/s: Build Tools
Affects Version/s: POMs 20
Fix Version/s: Build Tools 1.5.11, POMs 24

Type: Improvement Priority: Major
Reporter: Milan Divilek Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

NOTICE.txt contains bad URLs for main modules
eg.- magnolia-module-templating-components (http://www.magnolia-cms.com/magnolia-module-templating-components)

We could fix this URLs by outputing documentionURL when present and make sure we set documentationURL for all modules.



 Comments   
Comment by Magnolia International [ 23/Jan/12 ]

Yep, this is due to the <url> being specified for the main project, and Maven's strange inheritance behavior for urls, where it adds the submodule's artifactId to it.

Comment by Magnolia International [ 23/Jan/12 ]

As a side note, I am told on irc that <url> is used by the site plugin to generate some URLs. I don't see which at the moment, but it might be interesting to look into.

OTOH, I am not convinced we should keep on using the <url> tag for the main project. The notice already points to www.magnolia-cms.com in the attribution part, based on the <organization> tag. But Milan's suggestion of using the documentationURL property is not bad - and we wouldn't need to redefine it in submodules, since it's not inherited-with-artifactId-appended.

Comment by Magnolia International [ 29/Jun/12 ]

Ok, using documentationURL actually doesn't really fit, since it produces content like below - those URLs aren't relevant either as a pointer to the product.

This product includes/uses software(s) developed by 'Magnolia International Ltd.' (http://www.magnolia-cms.com)
  - magnolia-core (http://documentation.magnolia-cms.com/releases/4-4-7.html)
      License: GPLv3  (http://www.gnu.org/licenses/gpl-3.0.txt)
      License: Magnolia Network Agreement  (http://www.magnolia-cms.com/mna.html)
  - magnolia-gui (http://documentation.magnolia-cms.com/releases/4-4-7.html)
      License: GPLv3  (http://www.gnu.org/licenses/gpl-3.0.txt)
      License: Magnolia Network Agreement  (http://www.magnolia-cms.com/mna.html)

Comment by Magnolia International [ 29/Jun/12 ]

Thanks Milan, I finally found a way around this ! See the commits if you're curious

Generated at Sun Feb 11 23:38:37 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.