[BUILD-879] Review Renovate's postUpgradeTasks behaviour Created: 09/Aug/22  Updated: 11/Aug/22  Resolved: 11/Aug/22

Status: Closed
Project: Build
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Roberto Gomez Assignee: Roberto Gomez
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File results.csv    
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Team: Foundation

 Description   

Renovate's postUpgradeTask is meant to run once for each pull request:https://git.magnolia-cms.com/projects/BUILD/repos/boms/browse/renovate.json.

 

This past night's logs shows that Renovate called the VALIDATE_PR endpoint 11 times, and 11 times the fargate task was launched (see attached results.csv with tonight's task history). The weird thing is that all that 11 requests were made with the same parameters:

 
COMMAND_VALIDATEPR_RENOVATEBRANCH:renovate/release/6.2-patch-awssdkversion
COMMAND_VALIDATEPR_BRANCH:release/6.2
COMMAND_VALIDATEPR_SKIPRESTMODULE:true
COMMAND_VALIDATEPR_SKIPUITESTS:false
 
Seems that something is not working as expected on Renovate's side, since it should call the VALIDATE_PR job for each PR it creates and only once per PR.



 Comments   
Comment by Roberto Gomez [ 10/Aug/22 ]

After setting "executionMode": "branch" this night Renovate ran once per branch which is what we wanted. Also, it ran for the two branches Renovate updated,which also is what we wanted. It seems this night ran as expected.

Generated at Sun Feb 11 23:46:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.