[BUILD-98] Bundles created by new assembly plugin set wrong permissions on some files Created: 29/Feb/12  Updated: 13/Apr/17  Resolved: 12/Mar/12

Status: Closed
Project: Build
Component/s: Poms
Affects Version/s: POMs 21
Fix Version/s: Module Assembly 1.2.7, POMs 22

Type: Bug Priority: Blocker
Reporter: Milan Divilek Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by BUILD-80 Update assembly plugin to 2.2.1 Closed
is causing MAGNOLIA-4012 Explicitly set fileMode and directory... Closed
is causing MGNLEE-222 Explicitly set fileMode and directory... Closed
dependency
depends upon BUILD-100 Update assembly plugin to 2.3 Closed
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

New assembly plugin 2.2.1, used in new parent-pom 21, causes some odd permissions issues.

  • Owners used are those of ppl who last committed given file.
  • Permissions are wrong for folders in the webapps themselves - WEB-INF, META-INF and other folders have no permissions set at all.
    (The problem is best visible on linux. OSX tar/zip seems to use umask permissions for directories w/o permissions and obviously windows ignores issue all together. However linux tar/zip dutifully extracts folders as they were recorded in the archive making the installation unusable w/o resetting permissions and ownership.)

This issue might be related http://jira.codehaus.org/browse/MASSEMBLY-557

Example of corrupted archives: http://svn.magnolia-cms.com/svn/community/bundle/tags/magnolia-bundle-4.5-RC2/



 Comments   
Comment by Magnolia International [ 07/Mar/12 ]

I think the issue was related to http://jira.codehaus.org/browse/MASSEMBLY-595 or one of the others that was fixed in 2.2.2 or 2.3

The upgrade to 2.3 (BUILD-100) should take care of this. I've also updated the assembly descriptors we use for modules to explicitly set fileMode and directoryMode.

Now to the fix the tomcat bundles, you'll have to modify src/release/tomcat-bundle.xml and apply similar changes. I tried locally with the ce bundle, and it seems to fix it. I created MAGNOLIA-4012 and MGNLEE-222 to report the issue in the corresponding projects, and fixed their tomcat-bundle.xml files.

Can you please do the following:

  • report these changes to the necessary branches
  • test !
    • Update the projects to parent pom 22-snapshot
    • I wasn't able to reproduce the ownership issue.
    • Also check bundles produced modules, for example dms or stk !
    • .. as well as such bundles which are extracted in the bundles' add-ons folders.
  • Also check that all .sh files have the correct, and same, flags: find . -name "*.sh" -exec ls -al {} \;|awk ' {print $1}

    ' | sort | uniq -c

Comment by Ondrej Chytil [ 12/Mar/12 ]

None of the previous issues appeared during testing poms 22-SNAPSHOT.

Generated at Sun Feb 11 23:38:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.