[CAMPMAN-21] No Default Position When Adding Component Created: 02/Mar/21  Updated: 11/Feb/22  Resolved: 05/Mar/21

Status: Closed
Project: Campaign Manager
Component/s: None
Affects Version/s: 3.1.1
Fix Version/s: 3.1.2

Type: Bug Priority: Medium
Reporter: Chris Jennings Assignee: Alberto Cordero
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[X]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

Steps to reproduce

  1.  Create a new campaign and add an new creative item
  2.  Open the item for editing and add a component

Expected results

  • The new component dialog is displayed with a default selected in the add before/after radio button group. This assumption is based on the behaviour of the Pages app which defaults to "after".

Actual results

  • There is no default. Validation will force the user to select before or after.

Workaround

  • One can define a new dialog and override the definition of the action addComponent found in campaign-manager/includes/apps/campaign-manager-app-detail-actions.yaml

Development notes

  • The dialog is from pages-app. ie

{{addComponent:
$type: openDialogAction
dialogId: pages-app:newComponent
icon: icon-add-item
availability:
rules:
addible:
class: info.magnolia.pages.app.detail.action.availability.IsAreaAddibleRuleDefinition}}

This uses the old v5 UI. Swapping to the v6 dialog from pages (note: not pages-app) produces an error because of the datasource used in the background.


Generated at Sun Feb 11 23:55:20 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.