[CFGUI-171] Filtering in flat structure for definitions app Created: 18/May/23  Updated: 19/May/23  Resolved: 19/May/23

Status: Closed
Project: Definitions App
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Quach Hao Thien Assignee: Quach Hao Thien
Resolution: Won't Do Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
Cloners
clones MGNLUI-6347 Tree grid is not using limit/offset w... Closed
Relates
relates to CFGUI-114 Add DEBUG to #validateDefinition() in... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
CFGUI-172 CLONE - Implementation Sub-task To Do Quach Hao Thien  
CFGUI-173 CLONE - Review Sub-task To Do  
CFGUI-174 CLONE - PreintQA Sub-task To Do  
CFGUI-175 CLONE - QA Sub-task To Do  
CFGUI-176 CLONE - Fix failed IT test Sub-task To Do Quach Hao Thien  
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Grid performance
Story Points: 2
Team: Nucleus
Work Started:
Approved:
Yes

 Description   

Steps to reproduce

Filter in a tree view.

Expected results

Datasource fetches just visible items.

Actual results

Datasource fetches all items and treegrid renders those.

Development notes

Treegrid is not using offset/limit because a logic to judge which items are visible (think about expanded items) would be too complicated.
As we use flat structure while filtering, we might use the same logic as flat grid while filtering.



 Comments   
Comment by Roman Kovařík [ 18/May/23 ]

Unfortunately flat filtering in the definitions app hides all definition properties which are shown in the tree structure.

Doesn't this actually imply a bigger problem: we can't be sure that all data providers implement offset/limit properly in their hierarchical providers? https://git.magnolia-cms.com/plugins/servlet/search?q=FilterableHierarchicalDataProvider.wrap 

Wouldn't it be safer to move MGNLUI-6347  to a new TreeGridWithFlatFiltering extend TreeGrid and use it only where it is safe/tested (e.g. JcrTreePresenter, resources app...)? 

Comment by Quach Hao Thien [ 19/May/23 ]

Close as won't do: Definitions app won't need to filter in a flat structure

Generated at Mon Feb 12 00:45:43 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.