[CLOUDINARY-28] Add a property in Subapp descriptor to handle the initial open/close state Created: 14/Apr/23 Updated: 20/Apr/23 Resolved: 20/Apr/23 |
|
| Status: | Closed |
| Project: | Cloudinary DAM Connector |
| Component/s: | None |
| Affects Version/s: | 1.1.11 |
| Fix Version/s: | 1.1.12 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Raphael Falvo | Assignee: | Riste Drangovski |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[X] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Team: | |||||||||
| Work Started: | |||||||||
| Description |
|
Looking at following code, using closable property to handle wether a dam subapp shall be open or not (line 52) is not ideal and can lead to unwanted behavior as soon as cloudinary widget is installed with other dam modules, because we are iterating on all dam connector subapps (line 50) We shall create another property like defaultClosed or just closed for that behavior in cloudinary module to make sure that only cloudinary is impacted.
EDIT on Apr 18th This extra field has to be added at subapp descriptor level. If overriding the DamApp is needed, we need to make sure that it gets loaded after all other potential dam modules that could be added to a Magnolia bundle. Nevertheless, overriding DamApp is not ideal, if another dam module would also require a special behavior it would result in a dead end, as both would then require to have their own DamApp class loaded last. So if another way than overriding DamApp exists to consider the new property, we shall go that other way.
|