[COMMENTING-3] Move the database configuration to the module yaml file Created: 19/Feb/20  Updated: 24/Feb/20  Resolved: 24/Feb/20

Status: Closed
Project: Commenting
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: Improvement Priority: Neutral
Reporter: Adrien Manzoni Assignee: Riste Drangovski
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Epic Link: Core
Sprint: Scrum Sprint 1

 Description   

Instead of configuring the DB connection in the magnolia properties file, we should use the module yaml definition mechanism instead.

https://documentation.magnolia-cms.com/display/DOCS61/Module+configuration#Moduleconfiguration-anc-configuration-dataConfigurationdata



 Comments   
Comment by Adrien Manzoni [ 19/Feb/20 ]

 

datasource:
	username: user
	password: password
	url: jdbc:mysql://127.0.0.1:3306/comments
	driver: com.mysql.cj.jdbc.Driver
        currentUserProvider: info.magnolia.commenting.provider.MgnlCurrentUserProvider
	migration:
		path: dbmigration/mysql
		run: true
	

 

Comment by Adrien Manzoni [ 19/Feb/20 ]

rdrangovski

Do you think we can set the currentUserProvider a default value in the definition ?

Generated at Mon Feb 12 00:01:12 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.