[CONTDIFF-4] Request to Customize Property Names for Workspace Mapping Based on App and Subapp Created: 23/Nov/23  Updated: 04/Dec/23  Resolved: 04/Dec/23

Status: Closed
Project: Content Diff module
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0.1

Type: Improvement Priority: Neutral
Reporter: Cass Weber Assignee: Yen Lac Tue
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: 0.5h
Original Estimate: Not Specified

Attachments: PNG File image-2023-11-23-07-39-23-903.png    
Template:
Acceptance criteria:
Empty
Documentation update required:
Yes
Date of First Response:
Story Points: 0.5
Work Started:

 Description   

[Some words/texts have been modified for clarity.]

In the properties that can be configured from which workspace can be mapped to recover the data, the name of the properties should be by app/subapp, and not common to all apps.

  • For example, I can have a field award in app hotels, and it has to be recovered from the workspace hotel-awards. Also, I have a field award in app destinations, to be recovered from the workspace destination-awards.



 Comments   
Comment by Yen Lac Tue [ 27/Nov/23 ]

Hi cweber ,

Could you please help me clarify the description "Also, I have a field award in app destinations, to be recovered from the workspace destination-awards", as I wonder if the properties from customer data have the format like workspace-propertyName? If it does, I can simply split the format and get correct referenced workspace of that property.

Thanks!

Comment by Cass Weber [ 28/Nov/23 ]

Hi aramirez.henares, I hope you have access to this board. Would it be possible to clarify yen.lactue's inquiry in the previous comment? Thank you, Cass

Comment by Cass Weber [ 28/Nov/23 ]

Hi yen.lactue, I'm sharing Alberto's feedback directly:

About the question, we don’t have the properties in format like workspace-propertyName
The config should allow for each property to configure the property name and its workspace

Let me know if further information is needed,
Cass

Comment by Yen Lac Tue [ 29/Nov/23 ]

Hi cweber ,

I have this solution when working on ticket https://jira.magnolia-cms.com/browse/CONTDIFF-3

Now user can config multiple workspace, please help to take a look at this configuration

referencedConfigs:
  hotels:
    workspaceName: hotels
    referencedWorkspaces:
      award: hotel-awards
    depth: 2
  destinations:
    workspaceName: destinations
    referencedWorkspaces:
      award: destinations-awards
  website:
    workspaceName: website
    referencedWorkspaces:
      linkTypepage: website 

Explanation:

Case 1: When user add "Show content diff" function in hotels app, the workspace this function working on is hotels workspace. Then, system is looking for workspace name hotels in this configuration.

When get referenced for award property, it look up to hotel-awards workspace.

Case 2: When user add "Show content diff" function in destinations app, the workspace this function working on is destinations workspace. Then, system is looking for workspace name destinations in this configuration.

When get referenced for award property, it look up to destinations-awards workspace.

Could you please help to confirm if this solution match what they expected?

Again, thank so much for your help .

Yen Lac

Comment by Cass Weber [ 29/Nov/23 ]

Hi yen.lactue,

Here's additional feedback:

Remove the example of workspace (hotels) or at least comment it here: https://git.magnolia-cms.com/projects/INCUBATOR/repos/content-diff/pull-requests/5/diff#src/main/resources/content-diff/config.yaml We will add this config in the module configuration in magnolia configuration workspace.

Generated at Mon Feb 12 00:13:00 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.