[CONTEDIT-122] Implement visual design for video block Created: 22/Jun/17 Updated: 07/Aug/17 Resolved: 04/Aug/17 |
|
| Status: | Closed |
| Project: | Content Editor |
| Component/s: | None |
| Affects Version/s: | 1.0.5 |
| Fix Version/s: | 1.0.6 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Anja von Gunten | Assignee: | Sang Ngo Huu |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 4.75d | ||
| Original Estimate: | 3d | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||
| Epic Link: | Content Editor fine-tuning | ||||||||||||||||||||||||||||||||
| Sprint: | Saigon 102, Saigon 103, Saigon 104, Saigon 105, Saigon 106, Saigon 107 | ||||||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||||||
| Description |
|
The visual design of content blocks image / video / embed need to be adapted to the new look of the Stories app style. General characteristics:
Video option 1 from asset:
Video option 2 from embed code:
Mockup:
|
| Comments |
| Comment by Philip Mundt [ 24/Jul/17 ] |
|
When saving a video block and re-opening it, it fails with an exception:
Caused by: com.vaadin.data.util.converter.Converter$ConversionException: Unable to convert value of type java.util.LinkedList to presentation type interface java.util.Set. No converter is set and the types are not compatible.
at com.vaadin.data.util.converter.ConverterUtil.convertFromModel(ConverterUtil.java:118)
at com.vaadin.ui.AbstractField.convertFromModel(AbstractField.java:736)
at com.vaadin.ui.AbstractField.convertFromModel(AbstractField.java:721)
at com.vaadin.ui.AbstractField.setPropertyDataSource(AbstractField.java:657)
... 127 more
Pretty sure it has to do with the changes in its configuration...(my gut-feeling tells me OptionGroupFieldDefinition and/or multiselect=true). Additionally, no adjustements were made to any template. Pretty sure, that current state also doesn't work when rendering a video block (hint: various options were renamed to multivalued option called options). |
| Comment by Mikaël Geljić [ 24/Jul/17 ] |
|
right, even if we get the transformation working, we might want to consider whether or not we must be backward-compatible with the storing strategy until then. (hint: custom transformer) |