[CONTEDIT-130] Adjust and move generic components to main scope Created: 18/Jul/17 Updated: 19/Jul/17 Resolved: 19/Jul/17 |
|
| Status: | Closed |
| Project: | Content Editor |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Cedric Reichenbach | Assignee: | Unassigned |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
Currently, several components need to be explicitly declared in (sub-)app scope for modules implementing a content editor:
This is a unfortunate because those types are quite generic and most of the times, standard implementations from content-editor will be used, leading to unnecessary boilerplate configuration. However, we cannot directly move those definitions to content-editor yet because they would need to live in main scope, but have dependencies to (sub-)app-specific components. As a workaround, we could refactor those classes to lazy-load (sub-)app-related objects using factories/providers. After properly defining those components in content-editor, the corresponding entries in article-editor and stories-app can be dropped. |