[CONTEDIT-216] Test failure: OEmbedPeekProviderIT.metaTagsAreIgnored Created: 04/Nov/19 Updated: 04/Apr/23 Resolved: 04/Apr/23 |
|
| Status: | Closed |
| Project: | Content Editor |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Michael Duerig | Assignee: | Unassigned |
| Resolution: | Obsolete | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: | |
| Team: |
| Description |
|
This test relies on data of an external website (http://oembed.com), which apparently changed and now causes the test to fail: java.util.NoSuchElementException: No value present at java.util.Optional.get(Optional.java:135) at info.magnolia.unfurl.OEmbedPeekProviderIT.metaTagsAreIgnored(OEmbedPeekProviderIT.java:57) The reason that no value is present here is request parsing failing in the jsoup library. Most likely this is 1218 org.jsoup.UncheckedIOException: java.io.IOException: Mark invalid at org.jsoup.parser.CharacterReader.rewindToMark(CharacterReader.java:132) at org.jsoup.parser.Tokeniser.consumeCharacterReference(Tokeniser.java:182) at org.jsoup.parser.TokeniserState.readCharRef(TokeniserState.java:1698) at org.jsoup.parser.TokeniserState.access$100(TokeniserState.java:8) at org.jsoup.parser.TokeniserState$2.read(TokeniserState.java:36) at org.jsoup.parser.Tokeniser.read(Tokeniser.java:57) at org.jsoup.parser.TreeBuilder.runParser(TreeBuilder.java:55) at org.jsoup.parser.TreeBuilder.parse(TreeBuilder.java:47) at org.jsoup.parser.Parser.parseInput(Parser.java:35) at org.jsoup.helper.DataUtil.parseInputStream(DataUtil.java:169) at org.jsoup.helper.DataUtil.load(DataUtil.java:66) at org.jsoup.Jsoup.parse(Jsoup.java:118) at com.nmote.oembed.DefaultOEmbedProvider.document(DefaultOEmbedProvider.java:245) at com.nmote.oembed.DefaultOEmbedProvider.discover(DefaultOEmbedProvider.java:214) at com.nmote.oembed.DefaultOEmbedProvider.resolve(DefaultOEmbedProvider.java:165) at info.magnolia.unfurl.OEmbedPeekProvider.getPeek(OEmbedPeekProvider.java:54) at info.magnolia.unfurl.OEmbedPeekProviderIT.metaTagsAreIgnored(OEmbedPeekProviderIT.java:57) |
| Comments |
| Comment by Michael Duerig [ 04/Nov/19 ] |
|
To fix this we should rewrite these tests not to rely on external websites but use mocks instead. As an intermediate measure I propose to mark the affected test @Ignore. |
| Comment by Michael Duerig [ 04/Nov/19 ] |
|
Mreged PR 151 to get the build green again. |
| Comment by Laura Delnevo [ 04/Apr/23 ] |
|
Hello, This ticket is now marked as closed due to one of the following reasons:
If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you. Thank you, |