[CONTTAGS-105] Modify tags action doesn't have writePermissionRequired set in pages app Created: 06/Jan/21  Updated: 31/Dec/21  Resolved: 29/Dec/21

Status: Closed
Project: Content Tags
Component/s: None
Affects Version/s: 2.0.2
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Mercedes Iruela Assignee: Thuy To
Resolution: Duplicate Votes: 0
Labels: 623, maintenance, next-ui-backlog-sweep, to-verify
Remaining Estimate: Not Specified
Time Spent: 7.5h
Original Estimate: Not Specified

Issue Links:
Cloners
clones PAGES-353 writePermissionRequired is not set in... Closed
Relates
relates to MGNLUI-6404 Check correctness of settings of writ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Migrate apps to new UI framework
Sprint: Global Maintenance 4
Story Points: 1

 Description   

Timebox: 1 SP to verify.

writePermissionRequired is used to check writting permissions in a node. In the old pages app, it disabled all the actions that required write permisions. In the new pages app, not all the actions that requires write permissions in the node are including it, it leads to actions available and errors when trying to execute this actions.

This is the status of the action bar when a read-only permissions assigned to a node in new pages-app:

This is how it used to be in 5.7.*:

Steps to reproduce (bundle with travel-demo)

  1. As superuser, go to the Security App and configure user eric readonly permissions for website > sportstation (role: travel-demo-editor).
  2. Login as eric
  3. Go to pages app and click on /sportstation. See that almost all the actions are available. Choose one: Edit the page > Click on Edit Page Properties > Edit the dialog and save.

Expected result

When opening pages app and click on /sportstation(readonly), actions that require write permissions shouldn't be available.

Current result

You can select an action that requires writting permissions. An error comes up:

Workaround

Decorate the pages-app and add writePermissionRequired: true to all the actions that need it.

Development notes

We might preset writePermissingRequired in ModifyTagsAction|Definition so we don't need to set it in every app config explicitly.



 Comments   
Comment by Šimon Demočko [ 01/Feb/21 ]

I understand this is a duplicate (original) of the clone PAGES-353 and can be closed? The description nor summary does not seem to relate to content tags module. miruela, can we close this as obsolete? I briefly checked content-tags.yaml and writePermissionRequired seems to be well configured for the actions there.

Comment by Mercedes Iruela [ 23/Feb/21 ]

As we talked, this issue is a follow-up to tackle this:

We might preset writePermissingRequired in ModifyTagsAction|Definition so we don't need to set it in every app config explicitly.

Comment by Thuy To [ 29/Dec/21 ]

This issue was fixed in https://jira.magnolia-cms.com/browse/PAGES-353

Generated at Mon Feb 12 00:25:01 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.