[CONTTAGS-42] Remove dependency to personalization Created: 29/Sep/17  Updated: 20/Oct/17  Resolved: 12/Oct/17

Status: Closed
Project: Content Tags
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: Task Priority: Neutral
Reporter: Christoph Meier Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLEE-502 UI tests for a content-tagging scenario Closed
relation
is related to CONTTAGS-50 Remove personalization submodule Closed
is related to CONTTAGS-41 Content Tags polishing 4 Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: Tagging
Sprint: Kromeriz 116, Kromeriz 117, Kromeriz 118
Story Points: 3

 Description   

As an EE-Pro customer I would like to use content-tags independent from p13n.
It would have made sense to properly separate content-tags (the ui stuff, the workspace, etc.) and the tags-trait within distinct modules; TagsTrait could (or should?) be in a new submodule of the p13n reactor dependent on content-tags.



 Comments   
Comment by Milan Divilek [ 09/Oct/17 ]

Reopen:
This needs to be remove from magnolia-content-tags-core module descriptor (classes from ui submodule and they are defined also in ui submodule descriptor). This blocks whole UI admincentral if you use only content-tags-core module.

  <components>
    <id>subapp</id>
    <component>
      <type>info.magnolia.contenttags.shortcut.TagShortcutAwareBrowserPresenter</type>
      <implementation>info.magnolia.contenttags.shortcut.TagShortcutAwareBrowserPresenter</implementation>
    </component>
    <component>
      <type>info.magnolia.contenttags.shortcut.TagShortcutAwareWorkbenchView</type>
      <implementation>info.magnolia.contenttags.shortcut.TagShortcutAwareWorkbenchView</implementation>
    </component>
  </components>

There is plenty of <version> parameter usage in submodules poms, most of them are not needed because they are defined in dependencyManagement, but some of them should be moved dependencyManagement.

Comment by Antti Hietala [ 17/Oct/17 ]

mdivilek, let's not bundle the magnolia-content-tags-personalization module in the 5.6 release. The Tags trait needs more work. Including it in the bundle without documentation or demo would be confusing.

Comment by Roman Kovařík [ 18/Oct/17 ]

ahietala Milan Divilek, let's not bundle the magnolia-content-tags-personalization module in the 5.6 release.

I'd remove whole p13n submodule from git then.

cmeier I wondered why the bootsrap config.modules.content-tags-core.config.taggableWorkspaces.website.yaml resides in magnolia-content-tags-personalization.

It has to find page variants with tags trait. But if we'll remove the p13n module as mentioned above, you don't need to thing about it...

cmeier What is required however - the tours app is enabled for tagging

Seems that you have an old demo (the UI tests for tagging are passing).

Comment by Christoph Meier [ 18/Oct/17 ]

My point #2 above was wrong.
/modules/content-tags-core/config/taggableWorkspaces/tours is properly configured.

Generated at Mon Feb 12 00:24:24 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.