[CONTTAGS-9] Revisit creation of new tags Created: 07/Jul/17  Updated: 08/Sep/17  Resolved: 08/Sep/17

Status: Closed
Project: Content Tags
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Roman Kovařík Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Current impl for creation of new tags requires:

  • custom save action
  • tag manager

-Moreover current implementation duplicates saving of tags:- fixed by fixed by 7cb13d0116622c12ebd192d3a7924361bd3d4b53 (CONTTAGS-1)

  1. info.magnolia.contenttags.form.action.SaveDialogWithTagsAction#execute
  2. info.magnolia.contenttags.manager.TagManager#addTags
  3. then the mgnl:tags is overwriten by the standard save action (item.apply())--

Proposals:

A] create a custom wrapper which:

  1. overrides info.magnolia.jcr.wrapper.DelegateNodeWrapper#setProperty(java.lang.String, java.lang.String[]) and creates new tags on the fly
  2. also overrides session.save() so it saves also the new tags
    Benefits:
  3. Handling tags is not bound to UI anymore, but covers also setting tag via a rest endpoint
  4. We can drop some of the custom actions

B] JCR observer creates new, non existing tags
C] -Drop the tags workspace. Tags don't exist physically but are just words. We can still create a tag app which collects all existing tags. Collect information why was/is the workspace needed.- We need tag names for tag field suggestions



 Comments   
Comment by Roman Kovařík [ 08/Sep/17 ]

Closed as the current implementation/configuration was simplified.

Generated at Mon Feb 12 00:24:04 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.