[CONTTAGS-90] 'Tag name' is incorrectly applied to jcrName property Created: 24/Jun/20  Updated: 29/Sep/20  Resolved: 25/Sep/20

Status: Closed
Project: Content Tags
Component/s: None
Affects Version/s: None
Fix Version/s: 2.0.2

Type: Bug Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Sang Ngo Huu
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File bug-tag-name-content-types.png    
Issue Links:
Relates
relates to MGNLCT-143 jcrName field added in m6 content-typ... Closed
relates to MGNLUI-6007 Dynamic generated contentType based a... Closed
relates to MGNLUI-6073 Name property in content types does n... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: UI framework implementation
Sprint: UI FW 11
Story Points: 0.5

 Description   

The first field in contenttype generated apps is jcrName. Probably due to an errant i18n property, these are now all displayed as 'Tag Name' in the editor which is incorrect and confusing.

Ideally we do not need to expose a technical jcrName field to the user in M6 content-type based apps. (See linked ticket MGNLCT-143)

But if we do - then the default label needs to be changed from "Tag name" to "Name". Magnolia has a content tags feature and a marketing tags feature - so using "Tag Name" here is not just incorrect, but confusing and misleading.

"Name" will be a useful default for the entire system, but should be supplied in a more logical module - not in the Content Tags module. It can be overridden with a more specific key in each particular content app if needed.

 

 



 Comments   
Comment by Roman Kovařík [ 24/Jun/20 ]

This is caused by fields.jcrName.label=Tag name in a content tags i18n file.
The translation could be picked up randomly from there or from the correct translation (in UI framework) per each webapp restart.

https://git.magnolia-cms.com/plugins/servlet/search?q=fields.jcrName.label

Comment by Christopher Zimmermann [ 14/Jul/20 ]

I guess that key just needs its name fixed.

Comment by Mikaël Geljić [ 06/Aug/20 ]

key should likely be specialized/prefixed for content tags app

https://git.magnolia-cms.com/projects/ENTERPRISE/repos/content-tags/browse/magnolia-content-tags-ui/src/main/resources/content-tags-ui/i18n/content-tags-ui-messages_backend_en.properties#34

EDIT: and here too:
https://git.magnolia-cms.com/projects/ENTERPRISE/repos/content-tags/browse/magnolia-content-tags-ui-compatibility/src/main/resources/content-tags-ui/i18n/content-tags-ui-compatibility-messages_backend_en.properties#11

And here are the specialized keys for create/rename dialogs:

  • content-tags-ui.createTag.jcrName.label
  • content-tags-ui.renameTag.jcrName.label
Generated at Mon Feb 12 00:24:51 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.