[DEVDECT-7] Use maven artifact for third party mobileESP instead of including the source code Created: 02/Mar/12 Updated: 30/Apr/13 Resolved: 02/Mar/12 |
|
| Status: | Closed |
| Project: | Device Detection |
| Component/s: | None |
| Affects Version/s: | 1.0 |
| Fix Version/s: | 1.0.1 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Daniel Lipp | Assignee: | Daniel Lipp |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Description |
|
We're using [mobileESP|blog.mobileesp.com/] as device detection mechanism now. As it does not provided a maven artifact we had to include the source in our module. This is ugly and has the disadvantage that it's cumbersome to keep up to date. In addition it's not obvious to non-insiders that we're actually using it (e.g mvn dependency:tree won't reveal it). |
| Comments |
| Comment by Daniel Lipp [ 02/Mar/12 ] |
|
Removing that third-party source would also no longer spoil our code coverage. |