[DEVDECT-9] ClassCastException when retrieving MGNL_PREVIEW_ATTRIBUTE Created: 25/Apr/13  Updated: 02/May/13  Resolved: 30/Apr/13

Status: Closed
Project: Device Detection
Component/s: None
Affects Version/s: 1.0.2
Fix Version/s: 1.0.2

Type: Bug Priority: Major
Reporter: Daniel Lipp Assignee: Daniel Lipp
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MAGNOLIA-4728 Add demo-project / demo-features to c... Closed
duplicate
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

Up to now we could not manually force that exception but occasionally got it when building bundle on hudson.
e.g.: http://hudson.magnolia-cms.com/view/Product%20Team/job/magnolia-bundle_stable/50/console

[WARNING] [talledLocalContainer] 2013-04-24 18:30:06.404:WARN::/magnoliaTest/ftl-sample-site/ftl-products.html
[WARNING] [talledLocalContainer] java.lang.ClassCastException: java.lang.Boolean cannot be cast to java.lang.String
[WARNING] [talledLocalContainer] 	at info.magnolia.module.devicedetection.DeviceChannelResolver.resolveChannel(DeviceChannelResolver.java:65)
[WARNING] [talledLocalContainer] 	at info.magnolia.cms.filters.MultiChannelFilter.resolveChannel(MultiChannelFilter.java:104)
[WARNING] [talledLocalContainer] 	at info.magnolia.cms.filters.MultiChannelFilter.doFilter(MultiChannelFilter.java:79)
[WARNING] [talledLocalContainer] 	at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
[WARNING] [talledLocalContainer] 	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
[WARNING] [talledLocalContainer] 	at info.magnolia.module.cache.filter.GZipFilter.doFilter(GZipFilter.java:75)
[WARNING] [talledLocalContainer] 	at info.magnolia.cms.filters.OncePerRequestAbstractMgnlFilter.doFilter(OncePerRequestAbstractMgnlFilter.java:61)
[WARNING] [talledLocalContainer] 	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
[WARNING] [talledLocalContainer] 	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:85)
[WARNING] [talledLocalContainer] 	at info.magnolia.cms.security.auth.login.LoginFilter.doFilter(LoginFilter.java:93)
[WARNING] [talledLocalContainer] 	at info.magnolia.cms.filters.AbstractMgnlFilter.doFilter(AbstractMgnlFilter.java:91)
[WARNING] [talledLocalContainer] 	at info.magnolia.cms.filters.MgnlFilterChain.doFilter(MgnlFilterChain.java:83)
[WARNING] [talledLocalContainer] 	at info.magnolia.cms.filters.UnicodeNormalizationFilter.doFilter(UnicodeNormalizationFilter.java:90)


 Comments   
Comment by Daniel Lipp [ 30/Apr/13 ]

Old impl would only work if that attribute had not been set when DeviceChannelResolver#resolveChannel was called. This has been the case in normal execution but e.g. when fiddling around with request params one could easily provoke the ClassCastException. See SCRUM-1897 for more details.

Generated at Mon Feb 12 00:46:02 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.