[DOCU-19] quick start tutorial bugs Created: 23/Nov/04  Updated: 06/Dec/10  Resolved: 28/Dec/04

Status: Closed
Project: Documentation
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: Boris Kraft Assignee: Magnolia International
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

As mailed to me by Philipp Jurewicz

------ 8< -------

I worked trough templatersquickstart.pdf as a primer and found the following mistakes
you are also using non standard html tags like <nobr> and other things which prevent the output pages to be valid html pages (at least in the admin mode).

    • issue 1 **
      quote begin===========================
      4.3 Adapt the page template
      [...]
      <body bgcolor=<cms:out actpage="true"
      nodeDataName="bgcolor"/>>
      quote end=============================
      this will transformed to <body bgcolor=something> which is not valid html and in times of xml one should try to add quotes to html attributes
      <body bgcolor="something">
      I'm not sure how much though this is valid jsp (haven't done this for a while)
    • issue 2 **
      quote begin===========================
      5 Adding paragraphs
      [...]
      [...]
      [...]
      <cms:contentNodeIterator
      contentNodeCollectionName="contentParagraph">
      <cms:adminOnly>
      <tr>
      <td>
      <cms:editBar/>
      </td>
      </tr>
      </cms:adminOnly>
      <cms:includeTemplate/>
      </cms:contentNodeIterator>
      quote end=============================

this leads to unvalid HTML code! you shouldn't render between <tr> tags. I can't reproduce your screenshot

<tr>
<td>
<cms:adminOnly>
<cms:editBar/>
</cms:adminOnly>
<cms:includeTemplate/>
</td>
</tr>

makes more sence

    • issue 3 **
      quote begin===========================
      6. Dissecting paragraph templates
      [...]
      So let us have a look at the dialog definition at
      "Config/modules/templating/dialogs/samples/basicTemplate/textImage/".
      quote end=============================

basicTemplate
does not exist in 2.0 distribution



 Comments   
Comment by Fabrizio Giustina [ 23/Nov/04 ]

another little html "bug":
page 6 in the quickstart pdf

On we move to the body:
<body bgcolor="#ffffff">
<cms:mainBar paragraph="samplesPageProperties"/>
<br><h2>Hello World</h2></br>
</body>
</html>

the br tag can't have a body, the line
<br><h2>Hello World</h2></br>
should be:
<br><h2>Hello World</h2><br>

even better, entirely remove all the br tags:
<h2>Hello World</h2>

Wish: converting all the examples to valid xhtml strict (instead of html transictional) and remove tables... this will make the code more readable and clean.

Comment by Ortwin Glueck [ 23/Nov/04 ]

Fabrizio,

this is XHTML. It must read:
<br/><h2>Hello World</h2><br/>
to be correct.

I agree that br tags are evil, as margins and paddings are a CSS responsibility.

Ortwin Glück

Comment by Philipp Jurewicz [ 23/Nov/04 ]

Yes I would also support stricter standard HTML support, but it can happen piece by piece.

Comment by Fabrizio Giustina [ 23/Nov/04 ]

examples are not xhtml, the doctype is always set to html transitional.
See few lines above the previous sample:
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

Comment by Ortwin Glueck [ 23/Nov/04 ]

You are perfectly right, Fabrizio. I was getting confused by the JSP tags.

Comment by Boris Kraft [ 23/Nov/04 ]

Just want to report a typo in the pdf
templatersquickstart.pdf
page 6

"You will need to create the directory first,
as it ----- >us< ------ completely up to you how you name your templates, and "quickstart"
is just an example for the purpose of this tutorial."

should be "is"

Comment by Boris Kraft [ 28/Dec/04 ]

Issues 1-3 are fixed in the next release of the tutorial

Comment by Boris Kraft [ 28/Dec/04 ]

Issues fixed

Comment by Girish [ 06/Dec/10 ]

hello everyone can anyone please tell me the location of editParagraph.html.I cannot find it anywhere

Generated at Mon Feb 12 01:05:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.