[DOCU-58] mainBar instructions incorrect on website Created: 11/Sep/08  Updated: 28/Jul/11  Resolved: 11/Sep/08

Status: Closed
Project: Documentation
Component/s: content
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Major
Reporter: miles zarathustra Assignee: Antti Hietala
Resolution: Fixed Votes: 0
Labels: businesscritical, quality
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

irrelevant


Template:
Acceptance criteria:
Empty
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The information on

http://documentation.magnolia.info/userguide/templating/example/addmainbar.html

is a bit confused. It breaks horribly if you type it in as-is. It appears there was a half-hearted and possibly misguided attempt to upgrade the instructions from 3.5 to new features that were supposed to be in 3.6, plus something is possibly missing from the bundled templates.

magnolia 3.6
Below is the original code on the site. to get this to work, I had to change:

dialog to paragraph
mainbarParagraph to dmsParagraph

And, there is an unmatched </strong> tag.

Also, on the page
http://dev.magnolia.info/ref/latest-stable/magnolia-taglib-cms/tagreference.html
it says 3.6.1 at the upper left, but "this is version 3.5" in the content area.

<%@ page contentType="text/html;charset=UTF-8" language="java" %>
<%@ taglib uri="cms-taglib" prefix="cms" %>
<html>
<head>
<title><cms:out nodeDataName="title" /></title></head>
<body>
<cms:mainBar
dialog="mainbarParagraph"
label="Page Properties"
adminButtonVisible="true"/></strong>
<h1><cms:out nodeDataName="title" /></h1>
<p>Hello Magnolia World!</p>
</body>
</html>



 Comments   
Comment by Magnolia International [ 11/Sep/08 ]

Thanks a lot Miles !
I tried making some of this a little clearer:

  • The dialog attribute will indeed only be available in 3.6.2 (paragraph will still exist but dialog is preferred)
  • The name of the dialog is in fact totally up to you. Further down the page, we quickly explain how to create one. (well, there we just show how to copy an existing sample)
  • The confusion in version numbers is mostly due to the fact the up until now the tld files were maintained manually. Hopefully, starting with 3.6.2, this won't be the case anymore. See MAGNOLIA-1211.

Feel free to reopen if you feel this could be clarified further (well, it definitely could, we're hoping for reviewing the whole templating section soonish), or report more issues for other pages. Thanks again !

Comment by Antti Hietala [ 28/Jul/11 ]

Introduction to templating was revised extensively since the entry of this ticket. Add the mainBar procedure and its code examples were tested with Magnolia 4.x. Closing.

Generated at Mon Feb 12 01:05:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.