[DOCU-746] Contribution via pull requests Created: 10/Jun/16 Updated: 26/Sep/19 |
|
| Status: | Open |
| Project: | Documentation |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Neutral |
| Reporter: | Antti Hietala | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoR: |
Empty
|
||||
| Date of First Response: | |||||
| Description |
|
With the adoption of Bitbucket, we can now accept code contributions to Magnolia via pull requests. Rewrite the contribution instructions to explain how to make a pull request and the process of getting your contribution reviewed, approved and merged. |
| Comments |
| Comment by Michael Mühlebach [ 17/Jun/16 ] |
|
Ok there are several ways of working with pull requests:
A general good and easy understandable source for working with git is this guide: https://www.atlassian.com/git/tutorials/making-a-pull-request |
| Comment by Christoph Meier [ 12/Sep/16 ] |
|
According to pdrlocal, the environment is ready; users with an LDAP account already could fork and create pull requests. |
| Comment by Christoph Meier [ 23/Sep/16 ] |
|
ahietala - the sysadmins have confirmed that it is possible. Now the developers must agree in and have to figure out a "process" how to handle it. We need some process / or even tools to ensure that we get notified when an external guy is doing a pull request (PR). I was asking pmundt to discuss this topic in the next devops meeting. He probably will invit me for the next meeting |
| Comment by Michael Mühlebach [ 07/Nov/16 ] |
|
We probably want to update the description here as well: |
| Comment by Christopher Zimmermann [ 26/Sep/19 ] |
|
mgeljic Didnt you create a page about this? Where is that? Should probably be merged with this page - and both of them put in a high visibility spot - not burried under "support". https://documentation.magnolia-cms.com/display/DOCS62/Contribute#Contribute-Createpatches
|
| Comment by Mikaël Geljić [ 26/Sep/19 ] |
|
Indeed, Contribution Guidelines, linked. The current docu page is mostly outdated, suffers TL;DR; only thing the new page misses in comparison is the Contributor License Agreement (CLA, see sub-page), which they say should be signed and return by facsimile... Digital CLA/signature plugins might exist on Bitbucket and should be considered instead. |