[ECOMMERCE-496] Fix unstable test in TagProductsActionTest Created: 10/Feb/22  Updated: 18/Oct/22  Resolved: 11/Feb/22

Status: Closed
Project: E-commerce
Component/s: None
Affects Version/s: 1.2.6, 1.3.1
Fix Version/s: 1.3.2, 1.2.7

Type: Improvement Priority: Neutral
Reporter: Andrei Ichimescu Assignee: Jesus Alonso
Resolution: Fixed Votes: 0
Labels: authx
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: AuthorX improvements
Sprint: AuthorX 3
Story Points: 3

 Description   

Test : info.magnolia.ecommerce.decoration.action.TagProductsActionTest#verifyActionExecuteWithProduct is failing from time to time with NPE because of the

UI.setCurrent(ui);

 

AC:

  fix the unit test

 

Developer Notes:

   We can create a MagnoliaNotificationService that can handle the vaadin notifications. In the unit tests we can mock the service and not bother with setting the current UI.



 Comments   
Comment by Jesus Alonso [ 11/Feb/22 ]

The unit test is now fixed.

Generated at Mon Feb 12 01:44:39 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.