[ECOMMERCE-614] Review default limit for commercetools on child categories Created: 01/Dec/23  Updated: 13/Dec/23  Resolved: 01/Dec/23

Status: Closed
Project: E-commerce
Component/s: None
Affects Version/s: 1.3.5
Fix Version/s: 1.3.6

Type: Task Priority: Normal
Reporter: Alberto Soto Assignee: Alberto Soto
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: File SOC-ECOMMERCE-614.mp4    
Issue Links:
relation
is related to ECOMMERCE-543 Commerce tools: queries search only w... Closed
is related to ECOMMERCE-609 Port to master ECOMMERCE-543 Accepted
Sub-Tasks:
Key
Summary
Type
Status
Assignee
ECOMMERCE-615 Implementation Sub-task To Do  
ECOMMERCE-616 Review Sub-task To Do  
ECOMMERCE-617 Pre-Integration QA Sub-task To Do  
ECOMMERCE-618 QA Sub-task To Do  
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Team: AuthorX
Work Started:
Approved:
Yes

 Description   

Commerce tools connector provides a limit for parent categories too, which points to a subcategories limited to 20 items by default, which was not pointed in the previous ticket



 Comments   
Comment by Alberto Soto [ 01/Dec/23 ]

magnolia-ecommerce-commercetools-connector/src/main/java/info/magnolia/ecommerce/commercetools/categories/ByParentCategoryId.java shows a default query limit of 20 too, which was not pointed by our default dataset for demos.

 

Modify default values and tests are needed

After checking the rest of the queries:

  • Cart related queries do not support that method
  • All categories queries have been reviewed. (all, by parentCategoryId
  • Checkout queries do not support limit)
  • All product queries

In detail, method status will be  the following at the end of the ticket

CommercetoolsCartProvider     > no api for limit
All                                                 > limit overwritten
ById                                              > no needed
ByParentCategoryId                   > limit overwritten
ByProductId                                > no needed, but modified to allow casual usage in several categories
CommercetoolsCheckoutProvider > no api for limit
All                                                > limit overwritten
ByCategoryId                             > limit overwritten
ById                                             > no needed
SearchByText                             > limit overwritten

Generated at Mon Feb 12 01:45:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.