[ECOMMERCE-88] React to EcommerceDefinitionRegistry changes in EcommerceConnectionProvider Created: 22/Jan/19  Updated: 19/Feb/19  Resolved: 13/Feb/19

Status: Closed
Project: E-commerce
Component/s: None
Affects Version/s: None
Fix Version/s: 1.0

Type: Improvement Priority: Neutral
Reporter: Ilgun Ilgun Assignee: Ilgun Ilgun
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 3h
Original Estimate: Not Specified

Issue Links:
Relates
relates to ECOMMERCE-66 Rethink cache in Ecommerce Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Date of First Response:
Epic Link: Access the product catalogs
Sprint: Add-Ons 5
Story Points: 8

 Description   

Currently, EcommerceConnectionProvider is responsible to generate products and categories implementations for each connection at hand. However, those connection or implementations are subject to change. Those changes come from EcommerceDefinitionRegistry and hence provider should react upon those changes. 

 

Acceptance Criteria:

  • Create, delete, update connections upon definition changes
  • No need to call extra methods to generate implementations for connections (Registry updates should trigger this)
  • Ditch all caches for that definition
  • Ditch existing cache for changed line (might be tricky to implement, hence optional)


 Comments   
Comment by Trung Luu [ 29/Jan/19 ]

FYI, The updateView() method in AbstractConfigurationAction.java should be updated based on the implementation of this ticket. Thanks

Comment by Chuong Doan Huy [ 15/Feb/19 ]

Hi ilgun,

While doing QA for this ticket, i encounter a bug :

When i rename connection name in yaml file, the Catalogs subapp display both old and new connection (expect only one which is renamed).

Step to reproduce :

Start server with one connection (e.g connection-1)

Go to Resource app to edit yaml and rename "connection-1" to "connection-2"

Open Ecommerce app, at the Catalogs subapp, you will see both connection-1 and connection-2

(expect only see connection-2)

Thanks

Generated at Mon Feb 12 01:40:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.