[EXCONTRANS-428] Add support for MultiJcrBlockDefinition Created: 09/Jan/24  Updated: 01/Feb/24

Status: Reopened
Project: Content Translation Extended (CTX)
Component/s: None
Affects Version/s: None
Fix Version/s: 3.4.11

Type: New Feature Priority: Neutral
Reporter: Teresa Miyar Assignee: Yen Lac Tue
Resolution: Unresolved Votes: 1
Labels: None
Remaining Estimate: 0d
Time Spent: 3d 7h
Original Estimate: Not Specified

Attachments: File app-definition.yaml     PNG File body_multiJcrBlock.png     PNG File image-2024-01-23-08-56-20-273.png     File stories.yaml     PNG File supportedFieldDefinitions_fields.png    
Issue Links:
Cloners
is cloned by EXCONTRANS-432 Follow up on Add support for MultiJcr... Closed
dependency
Template:
Acceptance criteria:
Empty
Date of First Response:

 Description   

follow up on EXCONTRANS-412



 Comments   
Comment by Thomas Duffey [ 22/Jan/24 ]

Whatever work was done here did not actually add support for our multi JCR blocks.

Comment by Yen Lac Tue [ 23/Jan/24 ]

Hi tduffey ,

Could you please check this configuration /modules/translation/config/supportedFieldDefinitions to see if it have at least these field definitions are added.

And please make sure the appropriate field definition of translation field is added too, such as dotcom-richText

Many thanks!

Comment by Thomas Duffey [ 23/Jan/24 ]

Hello,
We implemented the above and still are unable to add our multiJCRblocks Here is the config: 
dotcom-richText is a RichTextFieldDefinition 

Comment by Thomas Duffey [ 24/Jan/24 ]

The team did a lot of debugging and provided the following:

  1. First issue is that we have nested composite fields and the existing 3.4.11 (And earlier) does not seem to handle that case. Some code updates are needed to to handle nested composite fields (Seems unrelated to Multi JCR Block support)
  2. We hacked something in place to deal with issue #1 but then we just hit the "MultiJcrBlockDefinition is not supported in this case" log warning from version 3.4.10

It looks to us like 3.4.11 does not actually include support for this. We're looking at the diff between 3.4.10 and 3.4.11 here:

https://git.magnolia-cms.com/projects/SERVICES/repos/content-translation-support-ext/compare/diff?sourceBranch=refs%2Ftags%2Fmagnolia-content-translation-support-ext-3.4.11&targetRepoId=1394&targetBranch=refs%2Ftags%2Fmagnolia-content-translation-support-ext-3.4.10#magnolia-content-translation-support-ext-core/src/main/java/info/magnolia/translation/ext/core/finder/DialogBasedPropertiesToTranslateFinderExt.java

In addition in the 3.4.11 release tag we're still seeing the "MultiJcrBlockDefinition is not supported..." warning on line 629 here:

 

https://git.magnolia-cms.com/projects/SERVICES/repos/content-translation-support-ext/browse/magnolia-content-translation-support-ext-core/src/main/java/info/magnolia/translation/ext/core/finder/DialogBasedPropertiesToTranslateFinderExt.java?at=refs%2Ftags%2Fmagnolia-content-translation-support-ext-3.4.11#629

Comment by Yen Lac Tue [ 24/Jan/24 ]

Hi tduffey ,

Thank a lot for your information.

I tried to reproduce by using the body part configuration from this yaml file app-definition.yaml(I get it from support ticket), and this is the decoration file I used to test, it contains body part stories.yaml

But it seem does not the right multiJcrBlock filed match with your case.
I will try to re-config it and fix it again.

Many thanks!

Comment by Thomas Duffey [ 24/Jan/24 ]

Hello,

I attached 2 files on the support ticket to help reproduce the issue we are having.

Comment by Yen Lac Tue [ 25/Jan/24 ]

Hi tduffey ,

Thank you so much for those attached files. I will investigate more and let you know the result ASAP.

Best regards!

Generated at Mon Feb 12 00:31:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.